1210231 - Decode unencrypted H.264 and AAC using Adobe's CDM on Windows (Vista, and K/N editions)

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Anthony says cpearce is already working on this.

Comment 1

[Chris Peterson [:cpeterson]]

cpearce is working on this for Windows (XP, Vista, and N editions without platform decoders), but the code should also work on Linux when Adobe delivers Linux builds of their CDM.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Enable decoding for unencrypted video via Adobe's GMP if available

* Move GMP PDM to the end of the PDMFactory's list, so that we prefer the WMF and other PDMs when creating decoders.
* Toggle the pref.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8674665 [details] [diff] [review]
Patch: Enable decoding for unencrypted video via Adobe's GMP if available

Review of attachment 8674665 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1833,5 @@
>  pref("media.eme.enabled", true);
>  pref("media.eme.apiVisible", true);
>  
> +// Decode using Gecko Media Plugins in <video>, if a system decoder is not
> +// availble and the preferred GMP is available.

available

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3cfb964dd761

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3cfb964dd761

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Release Note Request (optional, but appreciated)
[Why is this notable]: On Windows systems without platform H.264/AAC/MP3 decoders (Windows N and KN variants, and Windows Vista without the "Platform Update Supplement for Windows Vista" installed), HTML5 audio/video will now play MP4/H.264/AAC and MP3 using Adobe's Primetime EME plugin for decoding. Windows XP is still unsupported.

[Suggested wording]:

On Windows Vista and later versions of Windows, systems without platform H.264/AAC/MP3 decoders (Windows N and KN variants, and Windows Vista without the "Platform Update Supplement for Windows Vista" installed), HTML5 audio/video will now play MP4/H.264/AAC and MP3 using Adobe's Primetime EME plugin for decoding.

[Links (documentation, blog post, etc)]:

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Note: Adobe have not provided an EME plugin that works on Windows XP, so we can't use their plugin for MP4 playback on Windows XP yet.

Adjusting bug title to reflect that, so as to reduce confusion.

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Chris Pearce (:cpearce) from comment #6)
> [Links (documentation, blog post, etc)]:

Microsoft's decoders may be able to use hardware video decoding and will use less power than Adobe's CDM decoder. I think we should link to the SUMO page that describes how to install Microsoft's decoders for power users who are so inclined.

[Suggested wording]:

The Mozilla Support website describes how to download Microsoft's H.264/AAC/MP3 decoders, which are optimized to use hardware video decoding:

https://support.mozilla.org/en-US/kb/fix-video-audio-problems-firefox-windows

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3cfb964dd761

Comment 10

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Chris, could you provide a simplified wording? This one is too long and I am not even sure I understand it.
Thanks

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

[Suggested wording]:

On Windows Vista and later systems which don't have functioning MP4 audio/video decoders, Firefox will use the Adobe Primetime Content Decryption Module for decoding MP4 audio/video.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Added to the release notes with "On Windows Vista and later systems which don't have functioning MP4 audio/video decoders, the Adobe Primetime Content Decryption Module for decoding MP4 audio/video will be used" as wording.
However, I am pretty sure comms will propose something better :)

Comment 15

[Chris Peterson [:cpeterson]]

Sylvestre, decoding of unencrypted H.264 and AAC using the Adobe CDM has been disabled (by bug 1237145) due to Adobe AAC bug 1236756. We expect Adobe to deliver a fix later this week. Should we track bug 1236756 for release and/or remove this new rel note until the bug is fixed?

Comment 16

[Sylvestre Ledru [:Sylvestre]]

OK, removed from the release notes. Please resubmit when ready!