Closed Bug 1237407 Opened 6 years ago Closed 4 years ago

Use Firefox Account server's /.well-known/fxa-client-configuration to configure servers in Firefox for iOS

Categories

(Firefox for iOS :: Firefox Accounts, defect, P3)

Product:
Firefox for iOS
Component:
Firefox Accounts
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: nalexander, Assigned: vbudhram)

References

Details

(Whiteboard: [MobileCore][FxA])

Attachments

(2 files)

Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2609
55 bytes, text/x-github-pull-request
Details | Review
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3088
55 bytes, text/x-github-pull-request
jhugman
: review+
jhugman
: feedback+
Details | Review 
This is the iOS equivalent of Bug 1237406.  It's a little easier on iOS, I think, since we don't yet use any additional service endpoints (oauth, profiles, etc).
Product: Firefox for Android → Firefox for iOS
We now have a dedicated URL for this purpose: https://accounts.firefox.com/.well-known/fxa-client-configuration
Priority: -- → P3
Summary: Use Firefox Account server's openid-configuration to configure servers in Firefox for iOS → Use Firefox Account server's /.well-known/fxa-client-configuration to configure servers in Firefox for iOS
Assignee: nobody → vbudhram
Whiteboard: [ [MobileCore][FxA]
Whiteboard: [ [MobileCore][FxA] → [MobileCore][FxA]
Duplicate of this bug: 1204411
Exposes a debug option to use custom FxA servers for sync.
Attachment #8900363 - Flags: review?(jhugman)
Attachment #8900363 - Flags: review?(jhugman)
Comment on attachment 8900363 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3088

Updated based on comments, should be good for another review.
Attachment #8900363 - Flags: review?(jhugman)
Comment on attachment 8900363 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3088

A few nits, but really nice work.

Fix the nits and land!
Attachment #8900363 - Flags: review?(jhugman) → review+
Nits fixed and patch landed! Thanks!
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

What happened? The menu option has disappeared for 19.0. What's the story?

Flags: needinfo?(vbudhram)

S. Egbert, I'm not sure exactly why the menu would have been removed, but it looks like a couple other ones were as well. :gkeeley thoughts?

Flags: needinfo?(vbudhram) → needinfo?(gkeeley)

Certainly wasn't intentional! Leaving ni so I investigate this

Tapping the version number 5x WFM to show the additional menus

Flags: needinfo?(gkeeley)
You need to log in before you can comment on or make changes to this bug.