1237475 - about social error needs to use origin attributes properly

Status: RESOLVED WONTFIX

(Firefox Graveyard :: SocialAPI, defect)

Description

[Dave Huseby [:huseby]]

in the file browser/base/content/aboutSocialError.xhtml there's this code:

> 56       if (!config.origin) {
> 57         let URI = Services.io.newURI(url, null, null);
> 58         config.origin =
> 59           Services.scriptSecurityManager.createCodebasePrincipal(URI, {}).origin;
> 60       }

this needs to create a default context origin attribute from the origin and then use that when creating the codebase principal.

Comment 1

[Dave Huseby [:huseby]]

Attachment: Bug_1237475.patch

Comment 2

[Shane Caraveo (:mixedpuppy)]

TBH, I don't see the need here, this is just using a principle to get the origin (a string).  The principle instance isn't even held onto.  How are the attrs going to change the origin?

Comment 3

[Dave Huseby [:huseby]]

After looking deeper into this, we do not want any of the origin attributes to transmit into the use of createCodebasePrincipal.  Shane you're right, it's just getting the origin.  If we add origin attributes to it, you'll get an origin with a suffix which it will then try to parse, which is not what we want.  Using the default {} origin attributes will give us the correct behavior since user context id will be assigned the default value.