1237541 - [TV][2.5] Preview window back key also trigger on parent app window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

document.activeElement cannot focus immediately when browsing slow loading web page (ex: expedia.com) which causes parent app window will also back to previous page.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:fix-back-focus > mozilla-b2g:master

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8705166 [details] [review]
[gaia] rickychien:fix-back-focus > mozilla-b2g:master

I noticed that we forgot to set parentWindow.frontWindow = previewWindow; after preview window being created and also fix bug for focusManager.

Here is a small patch for addressing this issue.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

[Blocking Requested - why for this release]:

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8705166 [details] [review]
[gaia] rickychien:fix-back-focus > mozilla-b2g:master

Good job! Thanks.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Thank you Luke.

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/514132d2e74218d607963ae1fe4a4e0ded392f22

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8705166 [details] [review]
[gaia] rickychien:fix-back-focus > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1225081
[User impact] if declined: Unexpected UI behaviors when back key is triggered.
[Testing completed]: manual tested on local
[Risk to taking this patch] (and alternatives if risky): n/a
[String changes made]: n/a

Comment 7

[Josh Cheng [:josh]]

Comment on attachment 8705166 [details] [review]
[gaia] rickychien:fix-back-focus > mozilla-b2g:master

Approve for TV 2.5

Comment 8

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/d0d4b86a631027b4eb8d3a28c25b930dcb103bc2