Closed
Bug 1237651
Opened 9 years ago
Closed 9 years ago
TypeError: this.fxaPwInput is undefined at fxam_refresh_auth.js:92:1
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
yifan
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
No description provided.
|
Assignee | |
Updated•9 years ago
|
|
|
Assignee | |
Updated•9 years ago
|
Target Milestone: --- → 2.6 S5 - 1/15
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8705195 -
Flags: review?(yliao)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8705195 [details] [review] [gaia] ferjm:bug1237651.fxaPwInput > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): FxA [User impact] if declined: The user won't be shown the possibility of clearing an already typed password on the FxA refresh auth screen. [Testing completed]: Manual testing [Risk to taking this patch] (and alternatives if risky): Very low. Can't really get the situation worst as there's already a type error breaking the functionality. [String changes made]: None
Attachment #8705195 -
Flags: approval-gaia-v2.5?
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8705195 [details] [review] [gaia] ferjm:bug1237651.fxaPwInput > mozilla-b2g:master Thank you!
Attachment #8705195 -
Flags: review?(yliao) → review+
|
|
||
Comment 4•9 years ago
|
||
Merged in master: https://github.com/mozilla-b2g/gaia/commit/4a58f73622df06e28130181cc736edb0fbd26c6b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8705195 [details] [review] [gaia] ferjm:bug1237651.fxaPwInput > mozilla-b2g:master Approve for TV 2.5
Attachment #8705195 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
|
||
Comment 6•9 years ago
|
||
for 2.5 https://github.com/mozilla-b2g/gaia/commit/7e48ebfb6c7aad9dc2ef7e9525d1243a0a405ff9
You need to log in
before you can comment on or make changes to this bug.
Description
•