1237806 - Intermittent test_BufferingWait_mp4.html | Test timed out.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=19433827&repo=mozilla-inbound

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

44875 INFO Got a waiting event at 2.356824 which is smaller than 2.36843. (https://hg.mozilla.org/mozilla-central/file/c33f30666b37dbceffb9fbe5089a668db8893a85/dom/media/mediasource/test/test_BufferingWait_mp4.html#l53)

This timeout is not caused by the prerolling bug 1238347 because currentTime is greater than 1.57895 which means playback must have been started.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20d1fde10638&selectedJob=15265328
It can be easily reproduced by changing the interval of MDSM::UpdatePlaybackPositionPeriodically(). (https://hg.mozilla.org/try/rev/02b78f59ac82)

The fix is simple. We just need to update playback position again before entering BUFFERING mode so the currentTime of the media element would be more accurate.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb5a09ea7270

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

This should also address the problem in bug 1229987 comment 23.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1237806 - update playback position before entering buffering mode so the currentTime of the media element is more accurate during buffering. r=jya.

Review commit: https://reviewboard.mozilla.org/r/30297/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30297/

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8706264 [details]
MozReview Request: Bug 1237806 - update playback position before entering buffering mode so the currentTime of the media element is more accurate during buffering. r=jya.

mozreview crashes whenever i attempt to r+ it..

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ea8e549a96f

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7ea8e549a96f

Comment 10

[Chris Peterson [:cpeterson]]

JW: is your playback position fix something we should uplift to Aurora 45? Can this problem affect real world content?

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

No, this bug only affects the test cases.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Please request esr45 approval on this, assuming the risk is sufficiently low (OrangeFactor confirms that 45 is still hitting this failure intermittently).

Comment 13

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8706264 [details]
MozReview Request: Bug 1237806 - update playback position before entering buffering mode so the currentTime of the media element is more accurate during buffering. r=jya.

[Approval Request Comment]
User impact if declined:Intermittent test case failures which bother Sheriff and QA
Fix Landed on Version:46
Risk to taking this patch (and alternatives if risky): Low. The change is very simple.
String or UUID changes made by this patch: none

Comment 14

[Intermittent Failures Robot]

34 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 28
* fx-team: 5
* mozilla-central: 1

Platform breakdown:
* windows7-32: 21
* windows8-64: 13

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-03-21&endday=2016-03-21&tree=all

Comment 15

[JW Wang [:jwwang] [:jw_wang]]

(In reply to OrangeFactor Robot from comment #14)
> 34 automation job failures were associated with this bug yesterday.
> 
> Repository breakdown:
> * mozilla-inbound: 28
> * fx-team: 5
> * mozilla-central: 1
> 
> Platform breakdown:
> * windows7-32: 21
> * windows8-64: 13
> 
> For more details, see:
> https://brasstacks.mozilla.com/orangefactor/
> ?display=Bug&bugid=1237806&startday=2016-03-21&endday=2016-03-21&tree=all

checking...

Comment 16

[JW Wang [:jwwang] [:jw_wang]]

(In reply to OrangeFactor Robot from comment #14)
> 34 automation job failures were associated with this bug yesterday.
> 
> Repository breakdown:
> * mozilla-inbound: 28
> * fx-team: 5
> * mozilla-central: 1
> 
> Platform breakdown:
> * windows7-32: 21
> * windows8-64: 13
> 
> For more details, see:
> https://brasstacks.mozilla.com/orangefactor/
> ?display=Bug&bugid=1237806&startday=2016-03-21&endday=2016-03-21&tree=all

Some of recent timeouts are caused by bug 1258627.

Comment 17

[Carsten Book [:Tomcat]]

(In reply to JW Wang [:jwwang] from comment #16)
> (In reply to OrangeFactor Robot from comment #14)
> > 34 automation job failures were associated with this bug yesterday.
> > 
> > Repository breakdown:
> > * mozilla-inbound: 28
> > * fx-team: 5
> > * mozilla-central: 1
> > 
> > Platform breakdown:
> > * windows7-32: 21
> > * windows8-64: 13
> > 
> > For more details, see:
> > https://brasstacks.mozilla.com/orangefactor/
> > ?display=Bug&bugid=1237806&startday=2016-03-21&endday=2016-03-21&tree=all
> 
> Some of recent timeouts are caused by bug 1258627.

this is getting very frequent

Comment 18

[Intermittent Failures Robot]

48 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 32
* fx-team: 10
* mozilla-central: 5
* try: 1

Platform breakdown:
* windows7-32: 30
* windows8-64: 17
* osx-10-6: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-03-22&endday=2016-03-22&tree=all

Comment 19

[JW Wang [:jwwang] [:jw_wang]]

Some other timeouts are caused by bug 1258922. debugging...

Comment 20

[Intermittent Failures Robot]

53 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 36
* fx-team: 14
* mozilla-central: 3

Platform breakdown:
* windows7-32: 34
* windows8-64: 19

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-03-23&endday=2016-03-23&tree=all

Comment 21

[Intermittent Failures Robot]

167 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 114
* fx-team: 38
* mozilla-central: 13
* try: 2

Platform breakdown:
* windows7-32: 97
* windows8-64: 69
* osx-10-6: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-03-21&endday=2016-03-27&tree=all

Comment 22

[Intermittent Failures Robot]

17 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 8
* fx-team: 8
* mozilla-central: 1

Platform breakdown:
* windows8-64: 11
* windows7-32: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-03-29&endday=2016-03-29&tree=all

Comment 23

[Intermittent Failures Robot]

21 automation job failures were associated with this bug yesterday.

Repository breakdown:
* fx-team: 10
* mozilla-inbound: 9
* mozilla-central: 2

Platform breakdown:
* windows8-64: 12
* windows7-32: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-04-01&endday=2016-04-01&tree=all

Comment 24

[Intermittent Failures Robot]

48 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 23
* fx-team: 22
* mozilla-central: 3

Platform breakdown:
* windows8-64: 31
* windows7-32: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-03-28&endday=2016-04-03&tree=all

Comment 25

[Intermittent Failures Robot]

14 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 13
* fx-team: 1

Platform breakdown:
* windows8-64: 8
* windows7-32: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-04-04&endday=2016-04-10&tree=all

Comment 26

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8706264 [details]
MozReview Request: Bug 1237806 - update playback position before entering buffering mode so the currentTime of the media element is more accurate during buffering. r=jya.

Simplify the life of sheriff, taking it.
Should be in 45.1.0

Comment 27

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-esr45/rev/ef722522ea0c

Comment 28

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 5

Platform breakdown:
* windows7-32: 4
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-04-25&endday=2016-05-01&tree=all

Comment 29

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 5

Platform breakdown:
* windows7-32-vm: 3
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237806&startday=2016-06-27&endday=2016-07-03&tree=all

Comment 30

[Jean-Yves Avenard [:jya]]

What has happened in the past week for those to come back?

Comment 31

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

It looks like playback didn't resume after data was added after the first 'waiting' event.

In the past week there are only 4 occurrences within 4 hours of each other on 28 June.
The best candidate is bug 1281115 (add SetSeekThreshold for ffmpeg), which landed just before that and was backed-out shortly after for causing other timeouts.

So we're probably in the clear now. I'll add a note in bug 1281115 to watch out for this timeout too.

Comment 32

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=30771818#L2935

Decoder=111824a0 GetMediaTime=1623945 GetClock=1623945 mState=DECODING mPlayState=3 mDecodingFirstFrame=0 IsPlaying=0 mAudioStatus=waiting mVideoStatus=pending mDecodedAudioEndTime=2414873 mDecodedVideoEndTime=1696666 mIsAudioPrerolling=0 mIsVideoPrerolling=1:

Playback is not started because video is prerolling which is because of the pending video request (mVideoStatus=pending). We should check why the video request is not resolved.

Comment 33

[Jean-Yves Avenard [:jya]]

I don't see how it could be related to bug 12811115. That bug is ffmpeg related. 3 of the failures were on Windows where ffmpeg isn't used (and the test is about MP4)