1258627 - Sometimes MediaDecoderStateMachine gets stuck in buffering state forever

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/file/4037eb98974db1b1e0b5012c8a7f3a36428eaa11/dom/media/MediaDecoderStateMachine.cpp#l835

Consider the following situation when #l835 is reached:
1. We stop decoding audio for we have ample samples in the audio queue.
2. Video decoding reaches the end for OnNotDecoded() is invoked with |aType == MediaData::VIDEO_DATA|

We will not schedule next cycle because decoding is not complete and get stuck in buffering state forever.

We should always schedule next cycle even if decode is not complete so we have a chance to leave buffering state.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Btw, this bug is manifested by bug 1242783 which somewhat changes the amount of audio buffering and decode timing. We need also uplift the fix to 46.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1258627 - always schedule next cycle so MDSM has a chance to leave buffering state. r=cpearce.

Review commit: https://reviewboard.mozilla.org/r/41711/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41711/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Need to uplift to 46.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8733270 [details]
MozReview Request: Bug 1258627 - always schedule next cycle so MDSM has a chance to leave buffering state. r=cpearce.

https://reviewboard.mozilla.org/r/41711/#review38373

Feels like a hacky fix, but at least it's a fix.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3cab27bc9f80

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cab27bc9f80

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8733270 [details]
MozReview Request: Bug 1258627 - always schedule next cycle so MDSM has a chance to leave buffering state. r=cpearce.

Approval Request Comment
[Feature/regressing bug #]:unknown
[User impact if declined]:playback might get stuck forever when buffering
[Describe test coverage new/current, TreeHerder]:TreeHerder
[Risks and why]: very low for the change is very simple
[String/UUID change made/needed]:none

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8733270 [details]
MozReview Request: Bug 1258627 - always schedule next cycle so MDSM has a chance to leave buffering state. r=cpearce.

We don't want people's videos to be stuck, let's try uplift to beta 5.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0acea20bf3bb

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/de2b4f19530b