1238264 - Fix test for bug 87987

Status: ASSIGNED

(Thunderbird :: Message Compose Window, defect)

Description

[:aceman]

1. Fix and enable the part of test disabled in bug 1237565
2. Modify that part to account for bug 1232735

Comment 1

[Wayne Mery (:wsmwk)]

We should probably + tracking, to reduce risk as people start hacking on compose for version 52.

Comment 2

[:aceman]

Yes, even I want to start hacking on the identities again :)

Comment 3

[:aceman]

Still no luck:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1681f7a754bb

Comment 4

[aleth [:aleth]]

Is this wanted for 45?

Comment 5

[Jorg K (CEST = GMT+2)]

Makes no difference to the user. Eventually this should land so we have a test. I've taken the tracking off. Would be nice to get it one day.

Comment 6

[:aceman]

I've got a new version of the patch that passes on linux (https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b41564a4d3cc602de657f38ba87f787b17fb0377).

But it fails on other OSes :(

Jorg, can you run on Windows with the patch at https://hg.mozilla.org/try-comm-central/rev/532413ad159c89a1b3a4c92f13f74e612b676177 ? I need to know what the test does when it fails (around line 161, click_menus_in_sequence with identitykey2). Does the identity popup even open? If yes, at what location (at the right place or in the top left corner of the window)?

Comment 7

[Jorg K (CEST = GMT+2)]

Patch doesn't apply. You need the other one from the push. I'm building now, let's see what I can see. Jörg Čušťóm, right.

Comment 8

[Jorg K (CEST = GMT+2)]

All these test should have a line in them to paste into a command window to run the test quickly:
make SOLO_TEST=composition/test-newmsg-compose-identity.js mozmill-one

Comment 9

[Jorg K (CEST = GMT+2)]

Test passed locally. I'm not sure what I should look for.
> Does the identity popup even open? If yes, at what location.
Which identity popup? What should be the content?
Oops, second time it failed:
EXCEPTION: Popup never opened! id=msgIdentityPopup, state=showing

Didn't we see in some other bug that "showing" is not enough that that you need to wait for "open"?
https://hg.mozilla.org/comm-central/rev/ca4b376232c7386fc72fab6fc3b895fb60e90e4d#l1.12

Comment 10

[:aceman]

(In reply to Jorg K (GMT+2) from comment #9)
> Test passed locally. I'm not sure what I should look for.
> > Does the identity popup even open? If yes, at what location.
> Which identity popup? What should be the content?

The identity picker in the compose window (the From field). The last one we are trying to operate (somewhere around line 161), fails.

> Oops, second time it failed:
> EXCEPTION: Popup never opened! id=msgIdentityPopup, state=showing
> 
> Didn't we see in some other bug that "showing" is not enough that that you
> need to wait for "open"?

Yes, we are waiting, inside click_menus_in_sequence. I ask what do you see optically when that menupopup supposedly does not open. Did it really not open?

Comment 11

[Jorg K (CEST = GMT+2)]

You didn't answer:
> What should be the content?

There are many popups, so I don't know which one you're referring to. If I read the test correctly, it's the popup that should show when "Jörg Čušťóm" is in the From field, yes? There seems to be a popup that flashes up briefly.

Oh, I ran it again, this time the popup showed up for longer and I could even see a selection being made, about half-way down. The test still failed.

Shall I shoot you a video?

Comment 12

[Jorg K (CEST = GMT+2)]

I know you love random sleep, so this works:

  let identDrop = compWin.window.document.getAnonymousElementByAttribute(
                    compWin.e("msgIdentity"), "class", "menulist-dropmarker");
  compWin.click(new elib.Elem(identDrop), 5, 5);
  mc.sleep(500);
  compWin.click_menus_in_sequence(compWin.e("msgIdentityPopup"),
                                  [ { identitykey: identityKey2 } ]);
  checkCompIdentity(compWin, identityKey2, identity2From, identity2From);

Comment 13

[:aceman]

(In reply to Jorg K (GMT+2) from comment #11)
> You didn't answer:
> > What should be the content?
> 
> There are many popups, so I don't know which one you're referring to. If I
> read the test correctly, it's the popup that should show when "Jörg Čušťóm"
> is in the From field, yes? There seems to be a popup that flashes up briefly.

Yes.

> Oh, I ran it again, this time the popup showed up for longer and I could
> even see a selection being made, about half-way down. The test still failed.
> 
> Shall I shoot you a video?

Could be useful.