1238387 - Gradle build fails because suggested sites resource not found.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Johnson (:alex_johnson)]

Error: https://pastebin.mozilla.org/8856326
We need to remove the resource reference from UnusedResourcesUtil.java since it doesn't exist after bug 1216987.

Comment 1

[Alex Johnson (:alex_johnson)]

Attachment: MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle

Review commit: https://reviewboard.mozilla.org/r/30245/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30245/

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8706151 [details]
MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle

https://reviewboard.mozilla.org/r/30245/#review26975

Thanks for figuring this out.

::: mobile/android/base/java/org/mozilla/gecko/util/UnusedResourcesUtil.java
(Diff revision 1)
> -    public static final int[] USED_IN_SUGGESTEDSITES = {

IIRC, this file is used to stop linter warnings, so I think we'll need to swap the old images with the 5 new images:
suggestedsites_amazon.png
suggestedsites_facebook.png
suggestedsites_twitter.png
suggestedsites_wikipedia.png
suggestedsites_youtube.png

Comment 3

[Alex Johnson (:alex_johnson)]

Comment on attachment 8706151 [details]
MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30245/diff/1-2/

Comment 4

[Alex Johnson (:alex_johnson)]

Comment on attachment 8706151 [details]
MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30245/diff/2-3/

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8706151 [details]
MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle

https://reviewboard.mozilla.org/r/30245/#review26981

Great! Thanks for fixing this.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/30245/#review26983

Great! Thanks for fixing this.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/12b1cdd7b7da

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/12b1cdd7b7da