Closed
Bug 1238387
Opened 8 years ago
Closed 8 years ago
Gradle build fails because suggested sites resource not found.
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: alex_johnson, Assigned: alex_johnson)
References
Details
Attachments
(1 file)
Error: https://pastebin.mozilla.org/8856326 We need to remove the resource reference from UnusedResourcesUtil.java since it doesn't exist after bug 1216987.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/30245/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30245/
Attachment #8706151 -
Flags: review?(mark.finkle)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → me
Status: NEW → ASSIGNED
Comment 2•8 years ago
|
||
Comment on attachment 8706151 [details] MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle https://reviewboard.mozilla.org/r/30245/#review26975 Thanks for figuring this out. ::: mobile/android/base/java/org/mozilla/gecko/util/UnusedResourcesUtil.java (Diff revision 1) > - public static final int[] USED_IN_SUGGESTEDSITES = { IIRC, this file is used to stop linter warnings, so I think we'll need to swap the old images with the 5 new images: suggestedsites_amazon.png suggestedsites_facebook.png suggestedsites_twitter.png suggestedsites_wikipedia.png suggestedsites_youtube.png
Attachment #8706151 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8706151 [details] MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30245/diff/1-2/
Attachment #8706151 -
Attachment description: MozReview Request: Bug 1238387 - Removed the suggestsites resources ref from UnusedResourcesUtil.java r?mfinkle → MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle
Attachment #8706151 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8706151 [details] MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30245/diff/2-3/
Updated•8 years ago
|
Attachment #8706151 -
Flags: review?(mark.finkle) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8706151 [details] MozReview Request: Bug 1238387 - Updated suggested sites ref in UnusedResourcesUtil. r?mfinkle https://reviewboard.mozilla.org/r/30245/#review26981 Great! Thanks for fixing this.
Comment 6•8 years ago
|
||
https://reviewboard.mozilla.org/r/30245/#review26983 Great! Thanks for fixing this.
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/12b1cdd7b7da
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment hidden (spam) |
Updated•8 years ago
|
blocking-b2g: 2.2r? → ---
tracking-b2g:
backlog → ---
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•