1238549 - Manually importing Panorama into TabGroups (addon version) fails on first run

Status: RESOLVED INVALID

(Firefox Graveyard :: Panorama, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Steps:
1. Create a new profile.
2. Add Tab Groups Addon. !!!! - Do Not Open the addon after install.
3. Close the browser.
4. Replace the sessionstore.js with the renamed "tabgroups-session-backup.json" that contains deprecated panorama data to be restored.
5. Open the browser and open the Tab Groups (addon).

Actual Result:
Tab Groups are empty/not imported.

Expected Result:
Panorama data should have been imported into the addon Tab Groups.

Note/Workaround:
1. If at step 2. you open the tab groups or if you run the steps twice, the import will be successful.

Reproducible on: (*affects Win/Lin/Mac.)
45.0a2 (2016-01-11) | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
46.0a1 20160110030214 | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0

Comment 1

[:Gijs (he/him)]

I'm pretty sure you need to replace previous.js in the sessionstore folder, or use the add-on's "import" functionality if it has some. Have you tried either of those?

Either way, this isn't really a bug in Firefox. Why was it filed here?

Comment 2

[Adrian Florinescu [:aflorinescu]]

Our test case that takes in account using the manual restore of the tab groups failed, therefore we have logged this bug. It seems kind of obvious now that our test case and/or the information that was used to create it are incorrect, therefore based on that I would suggest we mark this bug as invalid.

However, we need to agree what happens in case of migration failure when the panorama feature is removed. As per your comment#1, the Tab Groups Addon/TabGroups Options - Load Migration Backup seems to be the logical choice - already tested and looks good. - please confirm if this is the main/official recovery option for lost panorama data. Maybe update the Sumo (https://support.mozilla.org/en-US/kb/tab-groups-removal) with these details - currently the Tab Groups Sumo contains only generic information on how to recover panorama data.

Comment 3

[:Gijs (he/him)]

(In reply to Adrian Florinescu [:AdrianSV] from comment #2)
> Our test case that takes in account using the manual restore of the tab
> groups failed, therefore we have logged this bug. It seems kind of obvious
> now that our test case and/or the information that was used to create it are
> incorrect, therefore based on that I would suggest we mark this bug as
> invalid.
> 
> However, we need to agree what happens in case of migration failure when the
> panorama feature is removed. As per your comment#1, the Tab Groups
> Addon/TabGroups Options - Load Migration Backup seems to be the logical
> choice - already tested and looks good. - please confirm if this is the
> main/official recovery option for lost panorama data. Maybe update the Sumo
> (https://support.mozilla.org/en-US/kb/tab-groups-removal) with these details
> - currently the Tab Groups Sumo contains only generic information on how to
> recover panorama data.

This information is already there:

https://support.mozilla.org/en-US/kb/tab-groups-removal#firefox:mac:fx45

You need to ensure you're looking at it with Firefox 45 (or configure the page for this on the left-hand side near the top). SUMO shows different things depending on your OS and Firefox version.