50.31 KB, patch
|Details | Diff | Splinter Review|
Xlib widget's clipboard code is broken in various ways, we have to rewrite it...
Hi, Roland I have almost finished rewriting xlib clipboard code, and can attach the patch after a few days. You can assign this bug to me. --Louie (firstname.lastname@example.org)
Louie Zhao wrote: > I have almost finished rewriting xlib clipboard code, and can attach the > patch after a few days. Wow! Thanks! :)) > You can assign this bug to me. Done!
Assignee: Roland.Mainz → Louie.Zhao
Created attachment 85577 [details] [diff] [review] rewriting of nsClipboard.cpp and nsClipboard.h of xlib Hi, Roland I have rewritten the xlib clipboard which implement almost all the features gtk clipboard has. You can try & test it, thanks. Two things can be done to make this code better. /* TODO: * 1. using INCR when writing data has some problem. * no INCR when data size < SEL_DELIMIT, so set * SEL_DELIMIT to large number to avoid INCR writing * * 2. when other app paste, don't support "TARGETS" * request to get all "TARGET"s in mozilla's copy data. * "TARGETS" request of internal paste works well. */ The two inperfection don't affect the using of xlib clipboard . Anyway, adding implementation of them will be better. BTW, who do you think suitable for reviewing and superviewing these code?
Louie Zhao wrote: > Created an attachment (id=85577) > rewriting of nsClipboard.cpp and nsClipboard.h of xlib > > I have rewritten the xlib clipboard which implement almost all the features > gtk clipboard has. WOW! Thanks! :) > You can try & test it, thanks. [snip] > BTW, who do you think suitable for reviewing and superviewing > these code? Per http://bugzilla.mozilla.org/survey.cgi?action=list I am a module "peer" (which means I can give you an r= or can say which r= is sufficient for me) and since this code is not part of the default build we do not need sr= ... :) I am reviewing this patch this weekend... In the meantime: - Did you test the patch with Rational Purify (my Purify still does not work... ;-( ) ? - Does the patch work in the en_US.UTF-8 and the gb18030 locales (using the CDE desktop) ?
I test the patch in the the en_US.UTF-8 and the gb18030 locales using the CDE desktop. It works well. I have tested: 1. copy webpage from another navigator(mozilla on gtk) to my composer(mozilla on xlib) 2. copy webpage from my navigator(mozilla on xlib) to another composer(mozilla on gtk). 3. copy webpage from my navigator(xlib) to my composer(xlib) These testings include copy & paste different kinds of data externally and internally, I think it's comprehensive. I have no Rational Purify on my machine, I can try later.
Hi, Roland Because I am busy recently, I am afraid I have no time to install and learn Rational Purify(:-(I didn't use it before). If your Rational Purify can work, can you test it? Thanks.
What happened to this bug (critical)? Has the clipboard code since then been fixed?
Louie, does this patch still apply? Maybe you should request review then ... or make it apply again before.
Xlib port has been removed from trunk (bug 326152) -> WONTFIX
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.