Split mochitest-other and add gtest

RESOLVED FIXED in Firefox 46

Status

Testing
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: armenzg, Assigned: armenzg)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
mochitest-other is running long on m1.medium
We can split it up. In fact, it was the intention to do the same for Buildbot (bug 1211889).

We also got Gtests greened up recently. We should add this to the list.
(Assignee)

Comment 1

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=481a798befd3
(Assignee)

Comment 2

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=beb9d3531c16
(Assignee)

Comment 3

2 years ago
Created attachment 8709081 [details]
MozReview Request: Bug 1239410 - Replace mochitest-other with a11y & chrome (3 chunks). DONTBUILD. r=jmaher

Review commit: https://reviewboard.mozilla.org/r/31249/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31249/
Attachment #8709081 - Flags: review?(jmaher)
(Assignee)

Comment 4

2 years ago
Created attachment 8709082 [details]
MozReview Request: Bug 1239410 - Add Linux64 debug tier2 GTest jobs + use desktop-test-xlarge workerType. DONTBUILD. r=jmaher

Review commit: https://reviewboard.mozilla.org/r/31251/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31251/
Attachment #8709082 - Flags: review?(jmaher)
Comment on attachment 8709081 [details]
MozReview Request: Bug 1239410 - Replace mochitest-other with a11y & chrome (3 chunks). DONTBUILD. r=jmaher

https://reviewboard.mozilla.org/r/31249/#review28085

this is good- if there is a good reason to add non a11y/chrome definitions, please let me know- otherwise remove them and land!

::: testing/taskcluster/tasks/branches/try/job_flags.yml:216
(Diff revision 1)
> +        task: tasks/tests/fx_linux64_mochitest_dt_e10s.yml

why are we adding devtools and browser chrome here?  they are not part of the s/m-oth/m-a11y:m-chrome/
Attachment #8709081 - Flags: review?(jmaher)
Attachment #8709082 - Flags: review?(jmaher)
Comment on attachment 8709082 [details]
MozReview Request: Bug 1239410 - Add Linux64 debug tier2 GTest jobs + use desktop-test-xlarge workerType. DONTBUILD. r=jmaher

https://reviewboard.mozilla.org/r/31251/#review28087

a few issues here- looks easy to address.

::: testing/taskcluster/tasks/branches/try/job_flags.yml:156
(Diff revision 1)
> +        task: tasks/tests/fx_linux64_crashtest.yml

we have crashtest duplicated here, same with gtest, I don't see that on other definitions.

::: testing/taskcluster/tasks/tests/fx_linux64_gtest.yml:20
(Diff revision 1)
> +    description: Gtests run {{chunk}}

we have chunk here but no extra variables defined for chunks.  Will that just default to "Gtests run" ?
(Assignee)

Comment 7

2 years ago
Comment on attachment 8709081 [details]
MozReview Request: Bug 1239410 - Replace mochitest-other with a11y & chrome (3 chunks). DONTBUILD. r=jmaher

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31249/diff/1-2/
Attachment #8709081 - Flags: review?(jmaher)
(Assignee)

Updated

2 years ago
Attachment #8709082 - Flags: review?(jmaher)
(Assignee)

Comment 8

2 years ago
Comment on attachment 8709082 [details]
MozReview Request: Bug 1239410 - Add Linux64 debug tier2 GTest jobs + use desktop-test-xlarge workerType. DONTBUILD. r=jmaher

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31251/diff/1-2/
Comment on attachment 8709082 [details]
MozReview Request: Bug 1239410 - Add Linux64 debug tier2 GTest jobs + use desktop-test-xlarge workerType. DONTBUILD. r=jmaher

https://reviewboard.mozilla.org/r/31251/#review28147
Attachment #8709082 - Flags: review?(jmaher) → review+
Comment on attachment 8709081 [details]
MozReview Request: Bug 1239410 - Replace mochitest-other with a11y & chrome (3 chunks). DONTBUILD. r=jmaher

https://reviewboard.mozilla.org/r/31249/#review28165
Attachment #8709081 - Flags: review?(jmaher) → review+
(Assignee)

Comment 11

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b79b3f8bfd22fd8eb06a4d5298a030203e5ad24d
Bug 1239410 - Replace mochitest-other with a11y & chrome (3 chunks). DONTBUILD. r=jmaher

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0d3ff1a5ecfa9546ffea893f2cb2bfb526cb4cf
Bug 1239410 - Add Linux64 debug tier2 GTest jobs + use desktop-test-xlarge workerType. DONTBUILD. r=jmaher

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b79b3f8bfd22
https://hg.mozilla.org/mozilla-central/rev/b0d3ff1a5ecf
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.