Closed Bug 1211889 Opened 7 years ago Closed 6 years ago

split mochitest-oth into- mochitest-a11y (a), mochitest-chrome (c1, c2, c3)


(Testing :: General, defect)

Not set


(Not tracked)



(Reporter: jmaher, Assigned: jmaher)




(3 files, 5 obsolete files)

with runbydir enabled for all of mochitest-chrome, I would like to split oth up.  a11y will be fast, but chrome takes a while and a bit longer with run-by-dir.  I propose 3 chunks for mochitest-chrome.
this will need:
* buildbot-configs
* trychooser syntax
* treeherder changes

I assume this will ride the trains starting in 44 on trunk and carry on.
Depends on: 1211905
I've filed bug 1211905 for the Treeherder parts (it's easier to track changes if they are in our component). Un CCing for now to reduce bugmail - once you know the buildernames drop a message in that bug :-)
Attached patch buildbot configs (1.0) (obsolete) — Splinter Review
these are buildbot configs, we still need mozharness changes for this to work, let alone other dependencies.
Assignee: nobody → jmaher
Attachment #8670349 - Flags: review?
Attached file bbconfig differences.txt (obsolete) —
Comment on attachment 8670349 [details] [diff] [review]
buildbot configs (1.0)

Review of attachment 8670349 [details] [diff] [review]:

This looks good to me
Attachment #8670349 - Flags: review? → review+
armen, this is needed prior to landing the buildbot changes, do let me know if I am overlooking something!
Attachment #8670390 - Flags: review?(armenzg)
Attachment #8670390 - Flags: review?(armenzg) → review+
Keywords: leave-open
landed code to split up m-oth:

when the next reconfig happens this will be live.
backed out, builder limits:
tst-linux64-spot-544 has 4131 builders; limit is 4084; 101 percent of max

:catlee, do I just need to find other tst-linux64-spot-544 jobs to disable?
Flags: needinfo?(catlee)
Depends on: 1215527
found some builders and landed:

tests passed successfully- this will get picked up in the next reconfig, just missed the one from today.
Flags: needinfo?(catlee)
These new jobs are all failing with  "Required config file not set! (use --config-file option)" at the start of the step.
Flags: needinfo?(jmaher)
Flags: needinfo?(armenzg)
Duplicate of this bug: 1173218
this is the command that is run when this was live:
 /tools/buildbot/bin/python scripts/scripts/ --mochitest-suite a11y --blob-upload-branch mozilla-inbound --download-symbols ondemand

and the error:
 Required config file not set! (use --config-file option)

for a dt5 run, we see this type of command executed:
/tools/buildbot/bin/python scripts/scripts/ --cfg unittests/ --mochitest-suite mochitest-devtools-chrome-chunked --total-chunks 8 --this-chunk 5 --blob-upload-branch mozilla-inbound --download-symbols ondemand

what appears to be missing is " --cfg unittests/ ".  Most likely we would need to add stubs similar to this for mochitest-a11y and mochitest-chrome-chunked:

and for osx and windows as well.  

:armenzg, can you confirm that, I would be happy to give this another go.
Flags: needinfo?(jmaher)
Yes, this is correct. I should have caught this in review.

It would be nice if would catch issues like this.
Flags: needinfo?(armenzg)
Attached patch buildbot configs (2.0) (obsolete) — Splinter Review
same bbconfig differences, just updated to have --cfg for each job type!
Attachment #8670349 - Attachment is obsolete: true
Attachment #8676886 - Flags: review?(armenzg)
Attachment #8676886 - Flags: review?(armenzg) → review+
landed this again:

will see if a reconfig yields success.
Backed out:

I will file a bug that will preven this happening in the future.
/tools/buildbot/bin/python scripts/scripts/ --mochitest-suite a11y --blob-upload-branch mozilla-inbound --download-symbols true
 in dir /builds/slave/test/. (timeout 1800 secs) (maxTime 1800 secs)
 watching logfiles {}
 argv: ['/tools/buildbot/bin/python', 'scripts/scripts/', '--mochitest-suite', 'a11y', '--blob-upload-branch', 'mozilla-inbound', '--download-symbols', 'true']
 using PTY: False
Required config file not set! (use --config-file option)
program finished with exit code 255
Armen, I am unclear on how this happened since we had this same error the first time and fixed it in the new patch/review.  some how we are missing the --cfg.
Flags: needinfo?(armenzg)
Before I backed out, I could not determine why it would failed (henced backed out).

This time I've noticed that this was only added for the 'linux' block and not 'linux64'.
Flags: needinfo?(armenzg)
ok, this should do the trick!
Attachment #8676886 - Attachment is obsolete: true
Attachment #8680242 - Flags: review?(armenzg)
Comment on attachment 8680242 [details] [diff] [review]
added configs for all platforms (3.0)

Review of attachment 8680242 [details] [diff] [review]:

Let's hope this time it works :)
Attachment #8680242 - Flags: review?(armenzg) → review+
Attached file builder changes (obsolete) —
backed out!

this time we needed builders to open aurora by adding more chunks.
the actual patch that was supposed to be backed out:
this previous patch is for all platforms, on linux32 debug we are hitting timeouts more frequently- for taskcluster (linux64 debug) we are already doing this split- for now lets adjust linux32 debug only.
Blocks: 1233953
Flags: needinfo?(jmaher)
Attachment #8680242 - Attachment is obsolete: true
Flags: needinfo?(jmaher)
Attachment #8711690 - Flags: review?(armenzg)
and the differences file
Attachment #8670350 - Attachment is obsolete: true
Attachment #8680583 - Attachment is obsolete: true
Comment on attachment 8711690 [details] [diff] [review]
oth -> a11y/c1/c2/c3 for linux32 debug only

Could you also please paste the list_builders_differences output for posterity? Thanks!
Attachment #8711690 - Flags: review?(armenzg) → review+
Do we want to make this change for linux64 as well?
we do, I couldn't land this last year because I hit the builder limits on linux64.
No longer blocks: 1233953
Closed: 6 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.