1239533 - [e10s] It's possible to accidentally get 2 visually selected tabs when opening tabs using window.open()

Status: RESOLVED DUPLICATE of bug 1157404

(Firefox :: Tabbed Browser, defect)

Description

[arni2033]

Attachment: testcase 1 - [e10s] It's possible to get 2 visually selected tabs .html

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160112030227
STR:
1.   Open "testcase 1"
2.A) Click on the page content (white area)
2.B) Right-click on the page content
2.C) Middle-click on the page content
    *If you see a "blocked popup" message, please allow popups for the domain and repeat Steps 1-2

Result:       At least 2 new tabs open, and last 2 of them look selected
Expectations: Only one tab should look selected

Note:
 You may see bug 1235850 or bug 1239532 on attached "testcase 1". There's no need to file them.

Comment 1

[Tracy Walker [:tracy]]

I've seen this recently as well, working on other test cases.

Curious, why is the test case producing multiple tabs in e10s but only one new tab in non-e10s?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

The problem here is that visuallySelected can be updated in two places - one place is within our async tab switcher, and the other place is within moveTabTo, which is used to place newly opened tabs next to their "related" tab. When you open several new tabs so that they go through the moveTabTo codepath, you end up in a state where visuallySelected is set on the newly opened tab, and _then_ on the newly selected tab.

This should only ever occur if you open several new tabs simultaneously such that they open next to the tab you're on (ie, they were redirected from window.open calls).

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Jeff, do you think this should block?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Duping to bug 1157404. I'll transfer the needinfo there.