1239719 - Please vendor the python requests library in mozilla-central

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Dan Minor [:dminor]]

Please package the python requests library in MozillaBuild. It will make reporting build system telemetry data much easier (see bug 1237610).

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I've been considering shipping mozregression with MozillaBuild, which would get this for free. One way or another, I'll include it in the next release.

Comment 2

[Gregory Szorc [:gps]]

I think we should vendor requests in mozilla-central instead. We already vendor it in version-control-tools.

Also, mach commands can install Python packages in the virtualenv used by the build system. Search for "activate_virtualenv" and "install_pip_package" in mozilla-central.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

In this case, I assume the chicken and egg situation (having it available prior to cloning m-c) doesn't apply since the work depending on it would also require a clone of m-c.

Dan, do you agree with comment 2?

Comment 4

[Dan Minor [:dminor]]

That's fine by me, my use case is reporting data after mach commands execute, so a clone of m-c will be available by then :)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Moving this over to Build Config then, thanks.

Comment 6

[Dan Minor [:dminor]]

Such a good idea, it seems we already did it [1] :)

[1] https://dxr.mozilla.org/mozilla-central/source/python/requests