Closed Bug 1239810 Opened 6 years ago Closed 6 years ago

test_UpdateUtils_url.js is going to permafail on Android 4.3 debug when Gecko 45 merges to Beta

Categories

(Toolkit :: Add-ons Manager, defect)

ARM
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox44 --- unaffected
firefox45 + fixed
firefox46 + fixed

People

(Reporter: RyanVM, Assigned: mossop)

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Merge day test failures

This has hit multiple pushes, but only on Android 4.3 debug?! I've verified that the opt runs show it running and passing.

https://treeherder.mozilla.org/logviewer.html#?job_id=15459747&repo=try

TEST-UNEXPECTED-FAIL | toolkit/modules/tests/xpcshell/test_UpdateUtils_url.js | test_locale - [test_locale : 200] the url param for %LOCALE% should equal the expected value - "null" == "en-US"
Flags: needinfo?(dtownsend)
I'm completely confused over how it is passing on the opt build, it should be failing on all android.
Assignee: nobody → dtownsend
Flags: needinfo?(dtownsend)
There's some weirdness around the way the updater is enabled/disabled/meant to be enabled but kinda disabled/meant to be disabled but enabled on Android, which was one of the bustages from the 44 merge to beta, it's possible that didn't get fixed above beta.
Bug 1232798, which did intend to fix it above beta, and has forgotten.
(In reply to Phil Ringnalda (:philor) from comment #3)
> There's some weirdness around the way the updater is enabled/disabled/meant
> to be enabled but kinda disabled/meant to be disabled but enabled on
> Android, which was one of the bustages from the 44 merge to beta, it's
> possible that didn't get fixed above beta.

As far as app update is concerned it no longer is enabled on Android as of Firefox 40 with bug 1152997 fixed. Android inappropriately reused MOZ_UPDATER but app update isn't compiled for Android and there is bug 1152634 to get Android to use a new define so I can remove the one-off code that makes Android not compile app update. The issue that Android has with
toolkit/modules/tests/xpcshell/test_UpdateUtils_url.js

is separate from app update which primarily lives in

toolkit/mozapps/update/
and
toolkit/xre/nsUpdateDriver.cpp

As for test_UpdateUtils_url.js does Android actually use UpdateUtils.jsm? If not, then I'd suggest excluding it on Android and disabling the test on Android.
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #5)
> As for test_UpdateUtils_url.js does Android actually use UpdateUtils.jsm? If
> not, then I'd suggest excluding it on Android and disabling the test on
> Android.

In general I'd like all general toolkit modules to be supported and work in all platforms where possible. Specifically here though we have been talking about wanting system add-ons to work for Android and that relies on UpdateUtils.jsm so we want this to work.
Tracking for 45+ to keep an eye on this as we have a week left till merge day.
Comment on attachment 8708112 [details]
MozReview Request: Bug 1239810: UpdateUtils.jsm requires the update.locale file to be shipped regardless of whether the application update is included. r?rstrong

Looks good on Try.
Attachment #8708112 - Flags: feedback+
Dave, I'm fine with this patch (it is simple enough afterall) but you should get someone on the Android team to also review it.
Comment on attachment 8708112 [details]
MozReview Request: Bug 1239810: UpdateUtils.jsm requires the update.locale file to be shipped regardless of whether the application update is included. r?rstrong

https://reviewboard.mozilla.org/r/30973/#review28175
Attachment #8708112 - Flags: review?(robert.strong.bugs) → review+
Attachment #8708112 - Flags: feedback+ → review?(nalexander)
Comment on attachment 8708112 [details]
MozReview Request: Bug 1239810: UpdateUtils.jsm requires the update.locale file to be shipped regardless of whether the application update is included. r?rstrong

https://reviewboard.mozilla.org/r/30973/#review28211

wfm.
Attachment #8708112 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/9004cc522119
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Please request Aurora approval on this.
Flags: needinfo?(dtownsend)
Comment on attachment 8708112 [details]
MozReview Request: Bug 1239810: UpdateUtils.jsm requires the update.locale file to be shipped regardless of whether the application update is included. r?rstrong

Approval Request Comment
[Feature/regressing bug #]: System add-ons
[User impact if declined]: Broken system add-on updates
[Describe test coverage new/current, TreeHerder]: Automated tests are catching the failures
[Risks and why]: Low risk, just adds a file to the distribution
[String/UUID change made/needed]: None
Flags: needinfo?(dtownsend)
Attachment #8708112 - Flags: approval-mozilla-aurora?
Comment on attachment 8708112 [details]
MozReview Request: Bug 1239810: UpdateUtils.jsm requires the update.locale file to be shipped regardless of whether the application update is included. r?rstrong

Fix a future permafail, taking it
Attachment #8708112 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
has problems during uplift :

grafting 324416:9004cc522119 "Bug 1239810: UpdateUtils.jsm requires the update.locale file to be shipped regardless of whether the application update is included. r=nalexander,rstrong"
merging mobile/android/installer/package-manifest.in
warning: conflicts while merging mobile/android/installer/package-manifest.in! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)
Flags: needinfo?(dtownsend)
It's a trivial rebase (I've been including it in various Try pushes for awhile now). I'll push it to Aurora in a few.
Flags: needinfo?(dtownsend)
You need to log in before you can comment on or make changes to this bug.