Application Reputation should honor browser.safebrowsing.allowOverride
Categories
(Toolkit :: Safe Browsing, defect, P3)
Tracking
()
People
(Reporter: francois, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
The browser.safebrowsing.allowOverride pref was added in bug 1226490 to disable users' ability to ignore Safe Browsing warnings. We should disable the "unblock" action on downloaded malware when that pref is enabled.
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Updated•8 years ago
|
Comment 1•6 years ago
|
||
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Reporter | ||
Updated•6 years ago
|
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
Essentially, if that pref is enabled, then the UI for ignoring a blocked download should not be available.
If you have any other questions, please NI :dimi since I'm no longer working on Firefox.
Comment 4•5 years ago
|
||
Comment 5•5 years ago
|
||
(In reply to Manish [:manishkk] from comment #4)
:dimi
Comment 3 by Francois already explained the idea of this bug, if you still have any question, you can ask and ni me again
Comment 6•5 years ago
|
||
I got only these 2 lines where pref is true.
https://searchfox.org/mozilla-central/source/browser/components/safebrowsing/content/test/browser_bug400731.js#50
https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#5596
These should be 'false' or anything else?
Comment 7•5 years ago
|
||
(In reply to Manish [:manishkk] from comment #6)
I got only these 2 lines where pref is true.
https://searchfox.org/mozilla-central/source/browser/components/safebrowsing/content/test/browser_bug400731.js#50
https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#5596These should be 'false' or anything else?
No, this bug doesn't mean to change the preference. Instead, we should honor the value of the preference.
That means you will need to find out where to disable the UX checkbox to "uncheck block download"
Updated•4 years ago
|
Comment 8•4 years ago
|
||
Hello, May I work on this?
Comment 10•4 years ago
|
||
Is it this?
Comment 11•4 years ago
|
||
Updated•4 years ago
|
Comment 12•4 years ago
|
||
(In reply to Jayati Shrivastava from comment #10)
Created attachment 9138299 [details]
checbox.pngIs it this?
Yes! Thank you for your help
Updated•4 years ago
|
Comment 13•3 years ago
|
||
This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Updated•2 years ago
|
Description
•