1239893 - Add gonk SidebandStream handling to DOMHwMediaStream

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Sotaro Ikeda [:sotaro]]

Gonk SidebandStream handling is not yet added to DOMHwMediaStream.

Comment 1

[Sotaro Ikeda [:sotaro]]

DOMHwMediaStream has DOMHwMediaStream::SetOverlayId(int32_t aOverlayId). Similar function is necessary to support gonk sideband stream.

https://dxr.mozilla.org/mozilla-central/source/dom/media/DOMMediaStream.cpp#1156

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add gonk SidebandStream handling to DOMHwMediaStream

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8709296 [details] [diff] [review]
patch - Add gonk SidebandStream handling to DOMHwMediaStream

Review of attachment 8709296 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/DOMMediaStream.cpp
@@ +1147,5 @@
> +  // Clear the old segment.
> +  // Changing the existing content of segment is a Very BAD thing, and this way will
> +  // confuse consumers of MediaStreams.
> +  // It is only acceptable for DOMHwMediaStream
> +  // because DOMHwMediaStream doesn't have consumers of TV streams currently.

Bug 1201363 will make this fixable in a principled way.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add gonk SidebandStream handling to DOMHwMediaStream

Update the comment. Carry "r=roc".

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=26052f941277

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add gonk SidebandStream handling to DOMHwMediaStream

Fix build failure.

Comment 7

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11e198ba0831

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/12b082de19be

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/12b082de19be