Closed Bug 1234472 Opened 4 years ago Closed 4 years ago

Add gonk sideband stream handling to gfx ipc

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 5 obsolete files)

native_handle_t is necessary to support SidebandStream
Assignee: nobody → sotaro.ikeda.g
Blocks: 1049296
Attached patch patch - Add GonkNativeHandle (obsolete) — Splinter Review
GonkNativeHandle imitates FenceHandle's implementation.

native_handle_t is defined in the following
  http://androidxref.com/6.0.0_r1/xref/system/core/include/cutils/native_handle.h#24
(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> Created attachment 8701016 [details] [diff] [review]
> patch - Add GonkNativeHandle

Implemantations of ParamTraits<GonkNativeHandle>::Write() and ParamTraits<GonkNativeHandle>::Read() refer android's Parcel::writeNativeHandle() and Parcel::readNativeHandle().

http://androidxref.com/6.0.0_r1/xref/frameworks/native/libs/binder/Parcel.cpp#854
http://androidxref.com/6.0.0_r1/xref/frameworks/native/libs/binder/Parcel.cpp#1338
Attached patch patch - Add GonkNativeHandle (obsolete) — Splinter Review
Attachment #8701016 - Attachment is obsolete: true
Depends on: 1205713
Attached patch patch - Add GonkNativeHandle (obsolete) — Splinter Review
Rebased.
Attachment #8701813 - Attachment is obsolete: true
Attached patch patch - Add GonkNativeHandle (obsolete) — Splinter Review
Update ImageClientSingle::UpdateImage()
Attachment #8703927 - Attachment is obsolete: true
Attachment #8703932 - Flags: review?(nical.bugzilla)
Comment on attachment 8703932 [details] [diff] [review]
patch - Add GonkNativeHandle

Review of attachment 8703932 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/GonkNativeHandle.h
@@ +18,5 @@
> +namespace mozilla {
> +namespace layers {
> +
> +#ifdef MOZ_WIDGET_GONK
> +class GonkNativeHandle {

Please add a quick comment about what this is useful for (a rough summary of what sideband stream is would be nice too, I had to look it up in android's source to figure it out)
Attachment #8703932 - Flags: review?(nical.bugzilla) → review+
Apply the comment.
Attachment #8703932 - Attachment is obsolete: true
Attachment #8704412 - Flags: review+
Summary: Add native_handle_t support on gecko ipc → Add gonk sideband stream handling to gfx ipc
Fix build failure. Carry "r=nical".
Attachment #8704412 - Attachment is obsolete: true
Attachment #8704455 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/bdaade557686
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Depends on: 1238602
Depends on: 1240659
See Also: → 1239893
You need to log in before you can comment on or make changes to this bug.