[TV][2.5] Tutorial should be merged into marketplace

VERIFIED FIXED

Status

VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: jyeh, Assigned: jyeh)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In order to solve the redirection problem in tutorial of marketplace, we should merge the tutorial page into the single page application of marketplace.
(Assignee)

Updated

3 years ago
Blocks: 1236810
(Assignee)

Updated

3 years ago
Assignee: nobody → jyeh
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8708236 [details] [review]
jostw:josyeh/Marketplace/master/Bug1239929 > mozilla-b2g:master

Hi Davor,

This patch might be hard to review because there are lots of refactoring inside.

I removed the stand-alone tutorial page and merge it into the marketplace. Since there are two views now, I extract two modules (smart_button.js, spatial_navigation.js) so both views can share the function.

Some of the event binding has changed the binding class name so it won't messed up the binding between two views.

Also reduce some code in tutorial.html and tutorial.styl thanks to the preprocessor.

You can leave any comments in the PR if you have any questions, thanks!
Attachment #8708236 - Flags: review?(dspasovski)

Updated

3 years ago
QA Whiteboard: [COM=TV::Web Apps]

Updated

3 years ago
Blocks: 1239346

Comment 2

3 years ago
Hi Davor,
Could you help to review the patch? We need to have marketplace ready for QA asap. 
Thank you!
Flags: needinfo?(dspasovski)
done
Flags: needinfo?(dspasovski)
Attachment #8708236 - Flags: review?(dspasovski) → review+
(Assignee)

Comment 4

3 years ago
Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/286d3dcc79cb71ff975782034608f18665a3220c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 5

3 years ago
verified and fixed with the latest build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.