1239929 - [TV][2.5] Tutorial should be merged into marketplace

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect)

Description

[Joseph Yeh [:joseph]]

In order to solve the redirection problem in tutorial of marketplace, we should merge the tutorial page into the single page application of marketplace.

Comment 1

[Joseph Yeh [:joseph]]

Attachment: jostw:josyeh/Marketplace/master/Bug1239929 > mozilla-b2g:master

Hi Davor,

This patch might be hard to review because there are lots of refactoring inside.

I removed the stand-alone tutorial page and merge it into the marketplace. Since there are two views now, I extract two modules (smart_button.js, spatial_navigation.js) so both views can share the function.

Some of the event binding has changed the binding class name so it won't messed up the binding between two views.

Also reduce some code in tutorial.html and tutorial.styl thanks to the preprocessor.

You can leave any comments in the PR if you have any questions, thanks!

Comment 2

[Josh Cheng [:josh]]

Hi Davor,
Could you help to review the patch? We need to have marketplace ready for QA asap. 
Thank you!

Comment 3

[Davor Spasovski [:spasovski]]

done

Comment 4

[Joseph Yeh [:joseph]]

Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/286d3dcc79cb71ff975782034608f18665a3220c

Comment 5

[Mike Lien[:mlien]]

verified and fixed with the latest build