1236810 - [TV][2.5] Patch for marketplace server setup

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P1)

Description

[Joseph Yeh [:joseph]]

Some patch need to be apply before marketplace server setup.

1. Endpoint of js-spatial-navigation in bower.json should be https based.
2. Routes should include '/tv' .
3. Locale files should included in build folder.
4. Assets' url should be relative.

Comment 1

[Joseph Yeh [:joseph]]

Attachment: jostw:josyeh/Marketplace/master/Bug1236810 > mozilla-b2g:master

Hi Davor,

This patch includes two commits. The first commit will add the route '/tv' so the routing won't failed on the TV Marketplace server.

The second commit looks like a bug in marketplace-template, settings_local_hosted.js seems different from settings_local.js.dist which caused a javascript error `ReferenceError: settings is not defined` on the TV Marketplace server.

Thanks!

Comment 2

[Joseph Yeh [:joseph]]

Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/25c0c49a998de84756d7f38f0a72dca0279790ee

Comment 3

[David Durst [:ddurst]]

If this has landed, I assume this is closed?

Comment 4

[Joseph Yeh [:joseph]]

I left this open because there are more issues needed to be solved :(

Comment 5

[Joseph Yeh [:joseph]]

Attachment: jostw:josyeh/Marketplace/master/Bug1236810 > mozilla:master

Comment 6

[Joseph Yeh [:joseph]]

Hi Allen,

I send a PR to zamboni repo with some updates for TV Marketplace settings (https://github.com/mozilla/zamboni/pull/3492), but it looks like the CI build has failed. Can you help me check if I made something wrong?

Thanks!

Comment 7

[Allen Short [:ashort]]

These tests intermittently fail and can be ignored. I don't see any problems introduced by your code.

Comment 8

[Joseph Yeh [:joseph]]

Thanks Allen. Looks good now.

Comment 9

[Joseph Yeh [:joseph]]

Attachment: jostw:josyeh/Marketplace/master/Bug1236810 > mozilla:master

Update icon url to production server in manifest.