1240193 - Convert test_auth_dialog_permission.js to use asyncOpen2

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1240193_asyncopen2_test_auth_dialog_permission.patch

Hey Dragana, just converting the test to use asyncOpen2. When doing so, mixed-content-blocker kicks in and would block requests, hence I had to change the schemes from https to http, which should be fine for the test, right?

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1240193_skip_type_document_assertions.patch

Tanvi, this is the last netwerk unit test we have to convert to use asyncOpen2(), then we could close Bug 1193558. I think it might still take some time till we have converted docshell (TYPE_DOCUMENT loads) to rely on asyncOpen2() and I don't want to hold back patches (like this one) that is ready to land.

Within Bug 1105556 [1] you added a hidden preference so we can skip assertions for TYPE_DOCUMENT loads created through JS. I would like to apply the same hidden pref trick for that test so we can get this patch landed and out of the way. What do you think?

Please note that within the contentsecuritymanager we could in fact remove the assertion, because contentpolicies bail out early for TYPE_DOCUMENT loads anyway, but I would like to keep the assertion so no one accidentaly calls asyncOpen2() for a TYPE_DOCUMENT load, hence I would rather just bypass the assertion for that specific test.

[1] https://hg.mozilla.org/mozilla-central/rev/5f8bcba5c5e0

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3883d00c447e
Skip TYPE_DOCUMENT assertions for loads initiated by JS tests (r=tanvi)
https://hg.mozilla.org/integration/mozilla-inbound/rev/9727e102e54b
Convert test_auth_dialog_permission.js to use asyncOpen2 (r=dragana)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3883d00c447e
https://hg.mozilla.org/mozilla-central/rev/9727e102e54b