124053 - Fix invalid use of JVMContext TLS to map between threads, JSContexts and JSJavaThreadStates

Status: RESOLVED FIXED

(Core Graveyard :: Java: OJI, defect)

Description

[Patrick C. Beard]

The OJI module has been playing fast and loose with JSContexts,
JSJavaThreadStates and mapping them to the current thread using thread local
storage. This is totally bogus, and needs to be cleaned up.

Comment 1

[Patrick C. Beard]

Attachment: Patch to clean up OJI module

This removes a ton of dead code, and begins to reform the use of the JVMContext
thread local storage mechanism.

Comment 2

[rpotts (gone)]

Attachment: Open this twice (each time in a new window)... Then crash when the windows are closed.

Comment 3

[Patrick C. Beard]

Taking.

Comment 4

[Patrick C. Beard]

Seeking reviews...

Comment 5

[Brian Nesse (gone)]

Comment on attachment 68261 [details] [diff] [review]
Patch to clean up OJI module

>+    JSContext *cx = nsnull;
>+    nsCOMPtr<nsIJSContextStack> stack = do_GetService("@mozilla.org/js/xpc/ContextStack;1");
>+    if (stack) stack->Peek(&cx);
> 
>     nsCSecurityContext *securityContext = new nsCSecurityContext(cx);

Not sure if there is really any point in creating this if cx is null, but it
handles the condition internally so I guess it doesn't matter. r=bnesse.

Comment 6

[Patrick C. Beard]

Need an sr.

Comment 7

[rpotts (gone)]

Comment on attachment 68261 [details] [diff] [review]
Patch to clean up OJI module

sr=[e-mail]

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in; marking fixed, please reopen if this is not actually fixed

Checking in src/jvmmgr.cpp;
/cvsroot/mozilla/modules/oji/src/jvmmgr.cpp,v  <--  jvmmgr.cpp
new revision: 1.42; previous revision: 1.41
done
Checking in src/lcglue.cpp;
/cvsroot/mozilla/modules/oji/src/lcglue.cpp,v  <--  lcglue.cpp
new revision: 1.53; previous revision: 1.52
done
Checking in src/lcglue.h;
/cvsroot/mozilla/modules/oji/src/lcglue.h,v  <--  lcglue.h
new revision: 1.8; previous revision: 1.7
done