1240549 - Put re-enter search mode functionality behind a switchboard flag

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

We landed bug 1022464 just on Nightly, but we haven't heard much feedback, so let's put it behind a switchboard flag so that we can roll it out to more users in a controlled manner.

Comment 1

[:Margaret Leibovic]

To be clear, we want to put this behind a switchboard flag to give ourselves a kill switch. We should enable this for all users by default.

Let's get a patch together for this soon, since this is moving to Aurora this week.

Comment 2

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1240549 - Remove unused imports. r=margaret

Review commit: https://reviewboard.mozilla.org/r/32721/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32721/

Comment 3

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1240549 - Put re-enter search mode functionality behind a switchboard flag. r=margaret

Review commit: https://reviewboard.mozilla.org/r/32723/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32723/

Comment 4

[:Margaret Leibovic]

Comment on attachment 8712962 [details]
MozReview Request: Bug 1240549 - Remove unused imports. r=margaret

https://reviewboard.mozilla.org/r/32721/#review29563

Comment 5

[:Margaret Leibovic]

Comment on attachment 8712963 [details]
MozReview Request: Bug 1240549 - Put re-enter search mode functionality behind a switchboard flag. r=margaret

https://reviewboard.mozilla.org/r/32723/#review29565

r+ if you move the string declaration to the Experiments class.

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:180
(Diff revision 1)
> +    public static final String EXPERIMENT_SEARCH_TERM = "search-term";

Add this to the Experiments class:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/util/Experiments.java

You could also move your onboarding experiment names to be declared in there as well.

And while we're at it, maybe we should add detailed comments above each experiment name explaining what it does and/or add the same docs in the switchboard-experiments repo.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cf7a94777727
https://hg.mozilla.org/integration/fx-team/rev/e810764b3d4d

Comment 7

[Chenxia Liu [:liuche]]

Done - I moved the onboarding experiments in bug 1242467.

Comment 8

[:Margaret Leibovic]

(In reply to Chenxia Liu [:liuche] from comment #7)
> Done - I moved the onboarding experiments in bug 1242467.

Thanks!

Remember to also make a PR to the switchboard-experiments repo to turn this feature on for users. I think we should turn it on for all users for now, but this will give us a way to roll back if necessary.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cf7a94777727
https://hg.mozilla.org/mozilla-central/rev/e810764b3d4d

Comment 10

[:Margaret Leibovic]

We should uplift this if we want to be able to turn this feature on in 46.

Comment 11

[Chenxia Liu [:liuche]]

Comment on attachment 8712963 [details]
MozReview Request: Bug 1240549 - Put re-enter search mode functionality behind a switchboard flag. r=margaret

Approval Request Comment
[Feature/regressing bug #]: Search mode
[User impact if declined]: Users will not be able to see search mode for search terms in this release
[Describe test coverage new/current, TreeHerder]: nightly
[Risks and why]: low, been on nightly for 2 cycles
[String/UUID change made/needed]: none

Comment 12

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Marking 46 as affected.

Comment 13

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8712963 [details]
MozReview Request: Bug 1240549 - Put re-enter search mode functionality behind a switchboard flag. r=margaret

Adds ability to turn new search feature (for 46) on and off. 
OK for uplift to aurora.

Comment 14

[:Margaret Leibovic]

Note: even when this is uplifted, it won't appear in Aurora builds until we make a change to our switchboard config to roll it out.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7939bc354e15