Closed Bug 1240549 Opened 4 years ago Closed 4 years ago

Put re-enter search mode functionality behind a switchboard flag

Categories

(Firefox for Android :: Awesomescreen, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox46 --- fixed
firefox47 --- fixed
fennec 46+ ---

People

(Reporter: Margaret, Assigned: liuche)

References

Details

Attachments

(2 files)

We landed bug 1022464 just on Nightly, but we haven't heard much feedback, so let's put it behind a switchboard flag so that we can roll it out to more users in a controlled manner.
tracking-fennec: --- → 46+
To be clear, we want to put this behind a switchboard flag to give ourselves a kill switch. We should enable this for all users by default.

Let's get a patch together for this soon, since this is moving to Aurora this week.
Summary: Staged rollout of re-enter search mode functionality → Put re-enter search mode functionality behind a switchboard flag
Attachment #8712962 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8712962 [details]
MozReview Request: Bug 1240549 - Remove unused imports. r=margaret

https://reviewboard.mozilla.org/r/32721/#review29563
Attachment #8712963 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8712963 [details]
MozReview Request: Bug 1240549 - Put re-enter search mode functionality behind a switchboard flag. r=margaret

https://reviewboard.mozilla.org/r/32723/#review29565

r+ if you move the string declaration to the Experiments class.

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:180
(Diff revision 1)
> +    public static final String EXPERIMENT_SEARCH_TERM = "search-term";

Add this to the Experiments class:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/util/Experiments.java

You could also move your onboarding experiment names to be declared in there as well.

And while we're at it, maybe we should add detailed comments above each experiment name explaining what it does and/or add the same docs in the switchboard-experiments repo.
Done - I moved the onboarding experiments in bug 1242467.
(In reply to Chenxia Liu [:liuche] from comment #7)
> Done - I moved the onboarding experiments in bug 1242467.

Thanks!

Remember to also make a PR to the switchboard-experiments repo to turn this feature on for users. I think we should turn it on for all users for now, but this will give us a way to roll back if necessary.
Flags: needinfo?(liuche)
https://hg.mozilla.org/mozilla-central/rev/cf7a94777727
https://hg.mozilla.org/mozilla-central/rev/e810764b3d4d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Flags: needinfo?(liuche)
We should uplift this if we want to be able to turn this feature on in 46.
Flags: needinfo?(liuche)
Comment on attachment 8712963 [details]
MozReview Request: Bug 1240549 - Put re-enter search mode functionality behind a switchboard flag. r=margaret

Approval Request Comment
[Feature/regressing bug #]: Search mode
[User impact if declined]: Users will not be able to see search mode for search terms in this release
[Describe test coverage new/current, TreeHerder]: nightly
[Risks and why]: low, been on nightly for 2 cycles
[String/UUID change made/needed]: none
Flags: needinfo?(liuche)
Attachment #8712963 - Flags: approval-mozilla-aurora?
Blocks: 1242467
Comment on attachment 8712963 [details]
MozReview Request: Bug 1240549 - Put re-enter search mode functionality behind a switchboard flag. r=margaret

Adds ability to turn new search feature (for 46) on and off. 
OK for uplift to aurora.
Attachment #8712963 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Note: even when this is uplifted, it won't appear in Aurora builds until we make a change to our switchboard config to roll it out.
You need to log in before you can comment on or make changes to this bug.