Closed
Bug 1240659
Opened 7 years ago
Closed 7 years ago
Add GonkNativeHandle::CreateDupNhObj()
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 4 obsolete files)
2.25 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
GonkNativeHandle expects that it always owns fd of native_handle_t. But there is a case that the assumption is not met. To handle the case, it seems better to add a function that just dups a native_handle_t for GonkNativeHandle::NhObj.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8709269 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•7 years ago
|
Attachment #8709269 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 2•7 years ago
|
||
Add error handling.
Attachment #8709269 -
Attachment is obsolete: true
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8709303 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8709305 -
Flags: review?(nical.bugzilla)
Comment 5•7 years ago
|
||
Comment on attachment 8709305 [details] [diff] [review] patch - Add GonkNativeHandle::CreateDupNhObj() Review of attachment 8709305 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/ipc/GonkNativeHandle.cpp @@ +42,5 @@ > > already_AddRefed<GonkNativeHandle::NhObj> > GonkNativeHandle::GetDupNhObj() > { > + return GonkNativeHandle::CreateDupNhObj(mNhObj->mHandle); IsValid() checks (mNhObj && mNhObj->mHandle). Does this mean that you may run in a crash if mNhObj is null here?
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Nicolas Silva [:nical] from comment #5) > Comment on attachment 8709305 [details] [diff] [review] > patch - Add GonkNativeHandle::CreateDupNhObj() > > Review of attachment 8709305 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: gfx/layers/ipc/GonkNativeHandle.cpp > @@ +42,5 @@ > > > > already_AddRefed<GonkNativeHandle::NhObj> > > GonkNativeHandle::GetDupNhObj() > > { > > + return GonkNativeHandle::CreateDupNhObj(mNhObj->mHandle); > > IsValid() checks (mNhObj && mNhObj->mHandle). Does this mean that you may > run in a crash if mNhObj is null here? Oh, sorry it is my mistake. I am going to update the patch. It should not crash.
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8709305 -
Attachment is obsolete: true
Attachment #8709305 -
Flags: review?(nical.bugzilla)
Attachment #8709744 -
Flags: review?(nical.bugzilla)
Updated•7 years ago
|
Attachment #8709744 -
Flags: review?(nical.bugzilla) → review+
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a24d6c2b7525
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•