1240660 - Remove support for "+" prefixes in jar manifests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove "+" prefixes in jar manifests

Now that the faster make backend is enabled by default avoiding
cross-jar.mn file conflicts, and now that individual files can't
overlap with wildcards in the same jar.mn files, which were two
main things that the "+" prefix was used for (apart from
cargo-culting), the "+" prefixes in the tree are not necessary
anymore.


This was generated with the following command:
find -name jar.mn | xargs grep -l '^ *\*\?+' | xargs sed -i 's/^\( *\*\?\)+/\1 /'

Comment 2

[Mike Hommey [:glandium]]

Attachment: Remove support for the "+" prefix in jar manifests

Comment 3

[Mike Hommey [:glandium]]

Attachment: Move jar_maker to the misc tier, now that ordering does't matter

Comment 4

[Mike Hommey [:glandium]]

Attachment: Move jar_maker to the misc tier, now that ordering does't matter

Comment 5

[Mike Hommey [:glandium]]

Attachment: Remove support for the "+" prefix in jar manifests

With an additional doc update.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8709297 [details] [diff] [review]
Move jar_maker to the misc tier, now that ordering does't matter

Review of attachment 8709297 [details] [diff] [review]:
-----------------------------------------------------------------

Oh boy - this is going to result in a huge build speedup, isn't it? \o/

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9041cb2cd652
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c30bc35d6e7
https://hg.mozilla.org/integration/mozilla-inbound/rev/de0a7a1cdc4a

Comment 8

[Mike Hommey [:glandium]]

Can't have nice things, I backed out the last part because of make package bustage
https://hg.mozilla.org/integration/mozilla-inbound/rev/9028e62ca761

Since it was a bonus, I'll move it to a separate bug.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9041cb2cd652
https://hg.mozilla.org/mozilla-central/rev/9c30bc35d6e7