Closed Bug 1241203 Opened 6 years ago Closed 6 years ago

Port Bug 1240660 to c-c [Remove support for "+" prefixes in jar manifests]

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 46.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Bug 1240660 removed the "+" prefix in jar.mn files. Not fixing this busts the builds.

This was generated with the following command from bug 1240660:
find -name jar.mn | xargs grep -l '^ *\*\?+' | xargs sed -i 's/^\( *\*\?\)+/\1 /'
According to aceman, there is nothing to do here.
Flags: needinfo?(acelists)
Attached patch jar.mn.patchSplinter Review
It also affects the im directory, so you are the best to review it.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8710045 - Flags: review?(aleth)
My build stopped at mail/components/compose/jar.mn
Comment on attachment 8710045 [details] [diff] [review]
jar.mn.patch

Review of attachment 8710045 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8710045 - Flags: review?(aleth) → review+
https://hg.mozilla.org/comm-central/rev/b5723697d212da88c9d358d46f1814e39800fd0f
Bug 1241203 - Port Bug 1240660 to c-c [Remove support for "+" prefixes in jar manifests]. r=aleth
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
I do not understand this. Yes, I said I see no + signs in any of our jar.mn. That is still true. I do not see them even in the file that are patched here. And my tree is from before the patch here. What is going on? Is this platform dependent in any way?
Flags: needinfo?(acelists)
This isn't platform dependent. On my Kubuntu I see it too. Also dxr sees it: https://dxr.mozilla.org/comm-central/source/mail/components/compose/jar.mn#17 in front of the line.
On a *just* cloned c-c I see no entries, but my cloned-a-while-ago comm-beta does:

callek@Centaurus:~/mozilla/hg$ grep "+" `find comm-central -name jar.mn `
callek@Centaurus:~/mozilla/hg$ grep "+" `find comm-beta -name jar.mn `
comm-beta/mail/base/jar.mn:*+  content/messenger/license.html                  (/mozilla/toolkit/content/license.html)
comm-beta/mail/components/compose/jar.mn:+   content/editor/editorOverlay.xul                               (content/editorOverlay.xul) 
comm-beta/im/content/jar.mn:*+	content/instantbird/license.html			(/mozilla/toolkit/content/license.html)
(In reply to Justin Wood (:Callek) from comment #8)
> On a *just* cloned c-c I see no entries, but my cloned-a-while-ago comm-beta
> does

The patch already landed 1 hour ago.
I tried to update now and get merge conflicts with this patch. My tree must be different to the official version. That is fishy.

$ hg pull
pulling from http://hg.mozilla.org/comm-central/
searching for changes
adding changesets
adding manifests
adding file changes
added 2 changesets with 18 changes to 18 files
(run 'hg update' to get a working copy)

$ hg update
merging im/content/jar.mn
warning: conflicts during merge.
merging im/content/jar.mn incomplete! (edit conflicts, then use 'hg resolve --mark')
merging mail/components/compose/jar.mn
warning: conflicts during merge.
merging mail/components/compose/jar.mn incomplete! (edit conflicts, then use 'hg resolve --mark')
16 files updated, 0 files merged, 0 files removed, 2 files unresolved
use 'hg resolve' to retry unresolved file merges
You need to log in before you can comment on or make changes to this bug.