1240825 - Schedule e10s crashtests on Windows 7

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

First we'll need to green them up, here's an initial try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=72e5d284087e

Comment 1

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1240825_config.py.patch

Attached you can find the patch to enable e10s crashtest

Comment 2

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1240825_config.py.output

Attached the difference

Comment 3

[Kim Moir [:kmoir] ET]

Comment on attachment 8709915 [details] [diff] [review]
bug1240825_config.py.patch

looks good, might want to ask jgriffin when he wants you to land it since the tests aren't green yet.  Or if he just wants you to enable them on try to start

Comment 4

[Vlad Ciobancai [:vladC] [:vciobancai]]

(In reply to Vlad Ciobancai [:vladC] from comment #1)
> Created attachment 8709915 [details] [diff] [review]
> bug1240825_config.py.patch
> 
> Attached you can find the patch to enable e10s crashtest

:jgriffin I created the patch to enable crashtest on e10s. Do you want us to enable them for try or we will wait for the tests to be green ?

Comment 5

[Jonathan Griffin (:jgriffin)]

(In reply to Vlad Ciobancai [:vladC] from comment #4)
> (In reply to Vlad Ciobancai [:vladC] from comment #1)
> > Created attachment 8709915 [details] [diff] [review]
> > bug1240825_config.py.patch
> > 
> > Attached you can find the patch to enable e10s crashtest
> 
> :jgriffin I created the patch to enable crashtest on e10s. Do you want us to
> enable them for try or we will wait for the tests to be green ?

Thanks Vlad; please wait for me to get the tests green.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28e722408379

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28e722408379

Comment 8

[Jonathan Griffin (:jgriffin)]

Vlad, the buildbot patch is ready to land now!

Comment 9

[Kim Moir [:kmoir] ET]

Comment on attachment 8709915 [details] [diff] [review]
bug1240825_config.py.patch

I landed this on behalf of Vlad since away for the rest of this week

Comment 10

[Kim Moir [:kmoir] ET]

in production

Comment 11

[Ryan VanderMeulen [:RyanVM]]

(In reply to Carsten Book [:Tomcat] from comment #7)
> https://hg.mozilla.org/mozilla-central/rev/28e722408379

Can we change this to asserts-if(winWidget&&e10s,0-1) please? Double-check my logic as I make no warranties of my reftest manifest-fu at this point :P

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Whoops, I believe we need to use browserIsRemote rather than e10s for reftests.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

(Also assuming it isn't a perma-assert that can just be set to 1 instead of 0-1)

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b09fe3ed3030

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b09fe3ed3030

Comment 16

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/releases/mozilla-beta/rev/971b0c37cf7c