Closed Bug 1240825 Opened 4 years ago Closed 4 years ago

Schedule e10s crashtests on Windows 7

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(e10s+, firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
Tracking Status
e10s + ---
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(2 files)

First we'll need to green them up, here's an initial try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=72e5d284087e
tracking-e10s: --- → +
Attached you can find the patch to enable e10s crashtest
Attachment #8709915 - Flags: review?(kmoir)
Attached the difference
Comment on attachment 8709915 [details] [diff] [review]
bug1240825_config.py.patch

looks good, might want to ask jgriffin when he wants you to land it since the tests aren't green yet.  Or if he just wants you to enable them on try to start
Attachment #8709915 - Flags: review?(kmoir) → review+
(In reply to Vlad Ciobancai [:vladC] from comment #1)
> Created attachment 8709915 [details] [diff] [review]
> bug1240825_config.py.patch
> 
> Attached you can find the patch to enable e10s crashtest

:jgriffin I created the patch to enable crashtest on e10s. Do you want us to enable them for try or we will wait for the tests to be green ?
Flags: needinfo?(jgriffin)
(In reply to Vlad Ciobancai [:vladC] from comment #4)
> (In reply to Vlad Ciobancai [:vladC] from comment #1)
> > Created attachment 8709915 [details] [diff] [review]
> > bug1240825_config.py.patch
> > 
> > Attached you can find the patch to enable e10s crashtest
> 
> :jgriffin I created the patch to enable crashtest on e10s. Do you want us to
> enable them for try or we will wait for the tests to be green ?

Thanks Vlad; please wait for me to get the tests green.
Flags: needinfo?(jgriffin)
Keywords: leave-open
Vlad, the buildbot patch is ready to land now!
Flags: needinfo?(vlad.ciobancai)
Keywords: leave-open
Comment on attachment 8709915 [details] [diff] [review]
bug1240825_config.py.patch

I landed this on behalf of Vlad since away for the rest of this week
Attachment #8709915 - Flags: checked-in+
in production
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Flags: needinfo?(vlad.ciobancai)
(In reply to Carsten Book [:Tomcat] from comment #7)
> https://hg.mozilla.org/mozilla-central/rev/28e722408379

Can we change this to asserts-if(winWidget&&e10s,0-1) please? Double-check my logic as I make no warranties of my reftest manifest-fu at this point :P
Flags: needinfo?(jgriffin)
Whoops, I believe we need to use browserIsRemote rather than e10s for reftests.
(Also assuming it isn't a perma-assert that can just be set to 1 instead of 0-1)
Status: RESOLVED → REOPENED
Flags: needinfo?(jgriffin)
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/b09fe3ed3030
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.