1240981 - Use BrowserLoader in performance tools

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Necessary for react components, for JIT view.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1240981-perf-browser-loader.patch

This is for using React/Redux.

* Removed all lazy loading; browser loader doesn't have that, and even if we did add that, it wouldn't be compatible with browserify/webpack-ish future. Most of these were already loaded anyway on start.
* marker-formatters was pulled out to avoid circular dependency after lazy loading was gone
* Manually unbind the preference listener -- for some reason, browser loader exposes this error; this was the cause of those leaks.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=66dd543781fb

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8710247 [details] [diff] [review]
1240981-perf-browser-loader.patch

Review of attachment 8710247 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/performance/performance-controller.js
@@ +3,5 @@
>   * You can obtain one at http://mozilla.org/MPL/2.0/. */
>  "use strict";
>  
>  var { classes: Cc, interfaces: Ci, utils: Cu, results: Cr } = Components;
> +//var { loader, require } = Cu.import("resource://devtools/shared/Loader.jsm", {});

already removed

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1240981-perf-browser-loader.patch

Some xpcshell tests failing because some components used the special observable PREFS object, and when the controller registers/unregisters now, the standalone unit tests never call the controller, meaning these getters are never loaded. So just using Services.prefs in these cases in marker-utils/marker-formatter.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f8633f954b8

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8710292 [details] [diff] [review]
1240981-perf-browser-loader.patch

Review of attachment 8710292 [details] [diff] [review]:
-----------------------------------------------------------------

Nice digging to find that leak!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/97866a808db2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/97866a808db2

Comment 7

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected