Closed Bug 1241087 Opened 8 years ago Closed 8 years ago

[SharedStubs] Enable shared stubs by default for ion

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: h4writer, Assigned: h4writer)

References

Details

Attachments

(1 file)

Seems like shared stubs is ready to be enabled by default when the next train departs.
Depends on: 1234663
Attached patch PatchSplinter Review
Looking to enable in FF47
Assignee: nobody → hv1989
Attachment #8709937 - Flags: review?(jdemooij)
Summary: [SharedStubs] Enableby default for ion → [SharedStubs] Enable shared stubs by default for ion
Comment on attachment 8709937 [details] [diff] [review]
Patch

Review of attachment 8709937 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8709937 - Flags: review?(jdemooij) → review+
Depends on: 1243754
Depends on: 1243757
This patch caused on AWFY:
7% regression on sunspider-validate-input (Mac 32 and 64bits)
34% regression on misc-bugs-608733-interpreter (Mac 64bits)
2% regression on misc-bugs-608733-interpreter (Mac 32bits)
7% regression on misc-forEach-baseline (Mac 64bits only)
5% regression on Octane-Crypto (Mac 32bits and Win 8)
5% regression on Octane-NavierStokes (Win 8)
11% regression on dromaeo-sunspider-string-tagcloud

4% improvement on misc-bugs-608733-trace-compiler (Mac 32bits only)
3% improvement on misc-f32-fft (Mac 32bits only)
32% improvement on dromaeo-jslib-event-jquery
Flags: needinfo?(hv1989)
https://hg.mozilla.org/mozilla-central/rev/ff5e2efa2f31
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Filed bug 1249252 for the regressions
Depends on: 1249252
Flags: needinfo?(hv1989)
Depends on: 1250964
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: