Closed
Bug 1241097
Opened 8 years ago
Closed 8 years ago
”Email link” option throws an error in Browser console
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox44 affected, firefox45 affected, firefox46 affected, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: vtamas, Assigned: crafuse)
References
Details
(Whiteboard: [btpp-fix-later])
Attachments
(2 files)
Reproducible on: Firefox 46.0a1, Firefox 45.0a2 and Firefox 44 RC across all platforms STR: 1.Start Firefox and Click on Hello icon. 2.Click on 'Get Started'. 3.Click on "Start a conversation" and send the link to another person. 4.Close the conversation. (from link generator side) 5.Click Hello icon and hover over one of the conversation listed. 6.Click the dropdown button and select Email Link. ER Users email default application opens with a new email form opened and there are no errors displayed in Browser Console. AR Users email default application is successfully opened but the following errors are thrown in Browser Console: [Dispatcher] Dispatching action Object { roomUrl: "https://hello.firefox.com/d_-uMhN3v…", from: "panel", name: "emailRoomUrl" } dispatcher.js:92:9 No URL sharing type bucket found for 'panel' utils.js:418:7 Additional notes: - This issue is reproducible on Firefox 46.0a1 (2016-01-19), Firefox 45.0a2 (2016-01-19) and Firefox 44 RC build 1 (20160118143821) under Windows 10 64-bit, Mac OS X 10.10.4 and Ubuntu 14.04 32-bit. - Room link: https://hello.firefox.com/d_-uMhN3vUk#4pNUppy7aj3df8wOeEWMZg
Updated•8 years ago
|
Whiteboard: [triage]
Comment 1•8 years ago
|
||
There's no SHARING_ROOM_URL.EMAIL_FROM_PANEL constant defined for a telemetry bucket: https://github.com/mozilla/loop/blob/master/add-on/chrome/modules/MozLoopService.jsm#L41 > const SHARING_ROOM_URL = { > COPY_FROM_PANEL: 0, The action still happens but ui tour and telemetry aren't notified of the email.
Updated•8 years ago
|
Rank: 25
Priority: -- → P2
Whiteboard: [triage] → [btpp-fix-later]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → crafuse
Comment 2•8 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8727960 [details] [review] [loop] chrafuse:bug-1241097-mail-link-option-throws-error-in-browser-console > mozilla:master EMAIL_FROM_PANEL is set to 5. No Errors.
Attachment #8727960 -
Flags: review?(edilee)
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment 4•8 years ago
|
||
Ed: Chris commented on the PR, can you take a look please?
Rank: 25 → 20
Flags: needinfo?(edilee)
Comment 5•8 years ago
|
||
Comment on attachment 8727960 [details] [review] [loop] chrafuse:bug-1241097-mail-link-option-throws-error-in-browser-console > mozilla:master You'll need a separate Histograms.json patch for m-c.
Flags: needinfo?(edilee)
Attachment #8727960 -
Flags: review?(edilee) → review+
Comment 6•8 years ago
|
||
To be clear, the add-on changes can land first as the Histograms.json already allows for 8 values.
Assignee | ||
Comment 7•8 years ago
|
||
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8745136 [details] [diff] [review] Email link option throws an error in console Histogram Here is the Histogram code and will push to m_c on review+.
Attachment #8745136 -
Flags: review?(edilee)
Updated•8 years ago
|
Attachment #8745136 -
Flags: review?(edilee) → review+
Assignee | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 9•8 years ago
|
||
Can you link to the loop and mozilla-central commits?
Flags: needinfo?(crafuse)
Assignee | ||
Comment 10•8 years ago
|
||
Loop https://github.com/mozilla/loop/pull/259/commits/402c3d9d5b3145431fd65e4daa8d459cf68fa008 MC Code, has not appeared in master or fx-team yet: https://bug1241097.bmoattachments.org/attachment.cgi?id=8745136
Flags: needinfo?(crafuse)
Comment 11•8 years ago
|
||
Do you need someone to check it in for you? Or do you need help checking it in yourself?
Flags: needinfo?(crafuse)
Comment 12•8 years ago
|
||
I don't think Chris has access. Let's get this marked as checkin-needed for attachment 8745136 [details] [diff] [review]
Status: RESOLVED → REOPENED
Flags: needinfo?(crafuse)
Keywords: checkin-needed
Resolution: FIXED → ---
Whiteboard: [btpp-fix-later] → [btpp-fix-later][checkin needed: attachment 8745136]
Comment 13•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/845ba221ebfd
Keywords: checkin-needed
Assignee | ||
Comment 14•8 years ago
|
||
Confirmed code change is now in Mozilla central fx-team.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Comment 15•8 years ago
|
||
This will get resolved when it makes it to mozilla-central not fx-team.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 16•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/845ba221ebfd
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•7 years ago
|
Whiteboard: [btpp-fix-later][checkin needed: attachment 8745136] → [btpp-fix-later]
You need to log in
before you can comment on or make changes to this bug.
Description
•