1241171 - FormData should not force 'blob' as filename.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

https://github.com/whatwg/xhr/issues/48

Comment 1

[Andrea Marchesini [:baku]]

Attachment: formData3.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8710197 [details] [diff] [review]
formData3.patch

Hopefully this is web compatible. Better to land early in the next cycle.

Comment 3

[ccd0]

The change made in Bug 1237595 breaks existing sites with an optional file field (https://boards.4chan.org/qa/thread/418502). So I hope this lands in 46 or is uplifted.

Comment 4

[Thomas Daede [:TD-Linux]]

Can confirm that this is needed in 46 to unbreak sites like 4chan, but 45 seems unaffected.

Comment 5

[Boris Zbarsky [:bzbarsky]]

[Tracking Requested - why for this release]: See comment 3.

Note that this means that either we ignore what comment 2 said or we back out bug 1237595 on 46 or something....

Comment 6

[Boris Zbarsky [:bzbarsky]]

Oh, and for future reference, it's generally a good idea to request tracking on regressions.  Or at least set the regression keyword...

Comment 7

[Andrea Marchesini [:baku]]

I'm ok with landing this patch if this fixes the regression.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a4b31e5c049

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/ad6293d247cb
Backout jobs: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ad6293d247cb

Jobs of failing push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3a4b31e5c049
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=20477679&repo=mozilla-inbound
03:42:57     INFO - TEST-START | /XMLHttpRequest/formdata-blob.htm
03:42:57     INFO - PROCESS | 1862 | ++DOCSHELL 0x7f8e09d2d000 == 5 [pid = 1910] [id = 39]
03:42:57     INFO - PROCESS | 1862 | ++DOMWINDOW == 17 (0x7f8e08ef2800) [pid = 1910] [serial = 114] [outer = (nil)]
03:42:57     INFO - PROCESS | 1862 | ++DOMWINDOW == 18 (0x7f8e09f05000) [pid = 1910] [serial = 115] [outer = 0x7f8e08ef2800]
03:42:58     INFO - PROCESS | 1862 | ++DOMWINDOW == 19 (0x7f8e09f0e000) [pid = 1910] [serial = 116] [outer = 0x7f8e08ef2800]
03:42:58     INFO - TEST-UNEXPECTED-FAIL | /XMLHttpRequest/formdata-blob.htm | formdata with blob - assert_equals: expected "\nkey=blob:text/x-value:5," but got "key=value,\n"
03:42:58     INFO - do_test/</client.onreadystatechange<@http://web-platform.test:8000/XMLHttpRequest/formdata-blob.htm:20:9
03:42:58     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
03:42:58     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
03:42:58     INFO - EventHandlerNonNull*do_test/<@http://web-platform.test:8000/XMLHttpRequest/formdata-blob.htm:18:35
03:42:58     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
03:42:58     INFO - do_test@http://web-platform.test:8000/XMLHttpRequest/formdata-blob.htm:16:5
03:42:58     INFO - @http://web-platform.test:8000/XMLHttpRequest/formdata-blob.htm:36:3
03:42:58     INFO - TEST-PASS | /XMLHttpRequest/formdata-blob.htm | formdata with named blob 
03:42:58     INFO - TEST-PASS | /XMLHttpRequest/formdata-blob.htm | formdata.append() should throw if value is string and file name is given 
03:42:58     INFO - TEST-OK | /XMLHttpRequest/formdata-blob.htm | took 1529ms

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fa27883caa1

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9fa27883caa1

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since this is a regression. Can you request uplift please since it looks like aurora 46 is affected?

Comment 13

[Andrea Marchesini [:baku]]

Comment on attachment 8710197 [details] [diff] [review]
formData3.patch

Approval Request Comment
[Feature/regressing bug #]: FormData spec is changed twice recently and we need this patch in order to have the latest changes. Without some website can be broken.
[User impact if declined]: Broken websites.
[Describe test coverage new/current, TreeHerder]: mochitests
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8710197 [details] [diff] [review]
formData3.patch

Compatibility issue, includes fixes for tests.
Please uplift to aurora.

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

Could we get this landed rather soon to unbreak web sites on Aurora.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c1621cd93127

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Several bad regressions here. baku can you take a look? Should this be backed out or do you think you can fix the regressions?

Comment 18

[Thomas Daede [:TD-Linux]]

This bug was fixing regressions caused by Bug 1237595, so you would need to back out both together.

Comment 19

[Andrea Marchesini [:baku]]

We have a working patch in bug 1246375.

Comment 20

[Liz Henry (:lizzard) (relman/hg->git project)]

Great, thanks baku, I took the uplift there.  How about bug 1247538 ?

Comment 21

[Andrea Marchesini [:baku]]

I would say that that bug is a duplicate. But I would like somebody else to help me testing it.

Comment 22

[Thomas Daede [:TD-Linux]]

On today's nightly, this bug is back - empty file upload fields now have filename="blob" again, breaking the same websites.

Comment 23

[Thomas Daede [:TD-Linux]]

[Tracking Requested - why for this release]:

Comment 24

[Andrea Marchesini [:baku]]

(In reply to Thomas Daede from comment #22)
> On today's nightly, this bug is back - empty file upload fields now have
> filename="blob" again, breaking the same websites.

Can you tell me more? I need an example to work on it. Thanks.

Comment 25

[Olli Pettay [:smaug][[e-mail]]]

new FormData(formElement) seems to cause the issue (if for form has <input type="file">). Someone please file a new bug where we deal with the regression. We really need to get back to the behavior beta has.

Comment 26

[Boris Zbarsky [:bzbarsky]]

I filed bug 1250148.  Re-resolving this one, since it was in fact fixed and the tests are still passing, so the remaining problem (whatever it is) is slightly different than whatever was fixed in this bug....

Comment 27

[Thomas Daede [:TD-Linux]]

Clearing ni because info was provided in bug 1250148.