1241469 - Explain missing event markers in Performance tool description

Status: RESOLVED WONTFIX

(Developer Documentation Graveyard :: Developer Tools, defect)

Description

[Sebastian Zartner [:sebo]]

The Performance panel within the DevTools has some filters, which need to be explained.

Specifically, there was a request on Stack Overflow[1] asking what 'CC Graph Reduction' means.

Sebastian

[1] http://stackoverflow.com/q/34922130/432681

Comment 1

[Will Bamberg [:wbamberg]]

I've added a bit on these to the table of markers: https://developer.mozilla.org/en-US/docs/Tools/Performance/Waterfall#Markers.

Let me know if it works for you.

Comment 2

[Sebastian Zartner [:sebo]]

Thanks for taking this! You changes already explain the 'CC Graph Reduction' event marker.
I'd believe the names should be called exactly like within the performance graph, i.e. 'Garbage Collection' should be renamed to 'Incremental GC' and we also need an entry for 'Minor GC'. Alternatively, we could list the event names under the 'Garbage Collection' entry like it's done for JavaScript events.

Note that I initially meant this report to be for explaining the filters within the filter menu, which have slightly different names, sometimes. I've created bug 1250795 for this instead.

Sebastian

Comment 3

[Will Bamberg [:wbamberg]]

(In reply to Sebastian Zartner [:sebo] from comment #2)
> Thanks for taking this! You changes already explain the 'CC Graph Reduction'
> event marker.
> I'd believe the names should be called exactly like within the performance
> graph, i.e. 'Garbage Collection' should be renamed to 'Incremental GC' and
> we also need an entry for 'Minor GC'. Alternatively, we could list the event
> names under the 'Garbage Collection' entry like it's done for JavaScript
> events.
> Note that I initially meant this report to be for explaining the filters
> within the filter menu, which have slightly different names, sometimes.

That's why I chose these names for this. That's what they are called in the filters. 

I think, actually, it's confusing that the names in the filter are almost, but not quite, the same as the names in the Performance view itself. I'm hesitant to have 2 huge tables that are almost identical. Would it be better for the Performance tool to use the same names in the filter that it uses for markers?

Comment 4

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to Will Bamberg [:wbamberg] from comment #3)
> That's why I chose these names for this. That's what they are called in the
> filters. 
> 
> I think, actually, it's confusing that the names in the filter are almost,
> but not quite, the same as the names in the Performance view itself. I'm
> hesitant to have 2 huge tables that are almost identical. Would it be better
> for the Performance tool to use the same names in the filter that it uses
> for markers?

I'm not sure I'm the best person to ni? for this (although what you're suggesting sounds logical).

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

I think tackling bug 1176540 would clear up a lot of these issues.

Comment 6

[Sebastian Zartner [:sebo]]

(In reply to Will Bamberg [:wbamberg] from comment #3)
> Would it be better
> for the Performance tool to use the same names in the filter that it uses
> for markers?

Regarding comment 5, it's still unclear to me what this means for the above question. I'm asking for clarification in bug 1250795.

Sebastian

Comment 7

[Sebastian Zartner [:sebo]]

(In reply to Will Bamberg [:wbamberg] from comment #3)
> I think, actually, it's confusing that the names in the filter are almost,
> but not quite, the same as the names in the Performance view itself.

I agree on that, btw. So, the filters should either be grouped more or be changed so that their names match the marker names.

Sebastian

Comment 8

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.