Closed Bug 1176540 Opened 9 years ago Closed 2 years ago

Marker Filters should be groupable

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(firefox41 affected)

RESOLVED WONTFIX
Tracking Status
firefox41 --- affected

People

(Reporter: jsantell, Unassigned)

References

Details

Attachments

(1 file)

This is because two markers are "nsCycleCollector::Collect" and "nsCycleCollector::ForgetSkippable" which render down to "Cycle Collection". We should consolidate these into the same filter, and probably be easiest to have them have the same marker name with meta indicating if its a minor or major CC, since we don't have anything in place to combine filters like that. If we did, we should probably combine all GC/CC markers in the same filter, and same with Parse HTML/XML.
Assignee: nobody → jsantell
Summary: Multiple cycle collection entries in filter list → Cycle Collection markers should only have one type, and have an extra reason
Assignee: jsantell → nobody
So these markers are ok to be different -- it looks like they represent different things. Although, we shouldn't have separate filters for these CC markers. In fact, we can probably group together several filters, like all GC/CC markers in one filter, Parse HTML and Parse XML in one filter, etc
Summary: Cycle Collection markers should only have one type, and have an extra reason → Marker Filters should be groupable
No longer blocks: perf-tools-fx43
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
Priority: -- → P2
Version: 41 Branch → unspecified
Priority: P2 → P3
Unassigning myself from bugs I won't be able to get to due to other commitments.
Assignee: jsantell → nobody
Status: ASSIGNED → NEW
Blocks: 1302129
Product: Firefox → DevTools

Now that we replaced the old performance panel by the Firefox Profiler (see Bug 1668219) we're closing bugs related to this.

Filter on MASSCLOSEOLDPERFTOOLBUGS.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: