Build bustage of Jan 21, 2016 in nsMsgComposeSecure.cpp caused by bug 1239455.

RESOLVED FIXED in Thunderbird 46.0

Status

Thunderbird
General
--
blocker
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Jorg K (GMT+2), Assigned: Jorg K (GMT+2))

Tracking

({regression})

Trunk
Thunderbird 46.0
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Mac compile error:
mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:908:51: error: too few arguments to function call, expected at least 6, have 5

Windows:
build/mailnews/extensions/smime/src/nsMsgComposeSecure.cpp(908) : error C2660: 'mozilla::psm::CertVerifier::VerifyCert' : function does not take 5 arguments

Linux:
mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:908:51: error: no matching function for call to 'mozilla::psm::SharedCertVerifier::VerifyCert(CERTCertificate*, int, mozilla::pkix::Time, std::nullptr_t, std::nullptr_t)'

https://dxr.mozilla.org/comm-central/source/mailnews/extensions/smime/src/nsMsgComposeSecure.cpp#908

Offending changeset:
https://hg.mozilla.org/mozilla-central/rev/bb6bfd172d6e
https://hg.mozilla.org/mozilla-central/diff/bb6bfd172d6e/security/certverifier/CertVerifier.cpp#l1.76
(Assignee)

Comment 1

a year ago
Patch coming up, need to wait for local compile.
(Assignee)

Comment 2

a year ago
Created attachment 8710501 [details] [diff] [review]
Bustage fix (v1).

This fixes the bustage to do with the CertVerifier::VerifyCert().

Next there are compile problems in TestAudioSegment.cpp, at least on Windows:

 1:55.39 C:\vs2013\VC\INCLUDE\xutility(1278) : error C2065: 'initializer_list' : undeclared identifier
 1:55.39 C:\vs2013\VC\INCLUDE\xutility(1278) : error C2065: '_Ilist' : undeclared identifier
 1:55.39 C:\vs2013\VC\INCLUDE\xutility(1281) : error C2433: 'rbegin' : 'inline' not permitted on data declarations
 1:55.40 C:\vs2013\VC\INCLUDE\xutility(1281) : error C2365: 'std::rbegin' : redefinition; previous definition was 'function'
 1:55.40 C:\vs2013\VC\INCLUDE\xutility(1281) : error C2998: 'std::reverse_iterator<const _Elem*> std::rbegin' : cannot be a template definition
 1:55.40 C:\vs2013\VC\INCLUDE\xutility(1284) : error C2065: 'initializer_list' : undeclared identifier
 1:55.40 C:\vs2013\VC\INCLUDE\xutility(1284) : error C2065: '_Ilist' : undeclared identifier
 1:55.40 C:\vs2013\VC\INCLUDE\xutility(1287) : error C2433: 'rend' : 'inline' not permitted on data declarations
 1:55.41 C:\vs2013\VC\INCLUDE\xutility(1287) : error C2365: 'std::rend' : redefinition; previous definition was 'function'
 1:55.41 C:\vs2013\VC\INCLUDE\xutility(1287) : error C2998: 'std::reverse_iterator<const _Elem*> std::rend' : cannot be a template definition

Perhaps someone can look into these.

Updated

a year ago
Blocks: 1239455

Updated

a year ago
Attachment #8710501 - Flags: review?(mkmelin+mozilla)

Comment 3

a year ago
(In reply to Jorg K (GMT+1) from comment #2)
> Next there are compile problems in TestAudioSegment.cpp, at least on Windows:
>  1:55.41 C:\vs2013\VC\INCLUDE\xutility(1287) : error C2998:
> 'std::reverse_iterator<const _Elem*> std::rend' : cannot be a template
> definition

:-( Sounds like a separate bug.
(Assignee)

Comment 4

a year ago
OK, here's a try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5e0c4a0a7c37
I want to see whether this compiles now and the std error is only my problems (to be solved by clobbering).

Comment 5

a year ago
Comment on attachment 8710501 [details] [diff] [review]
Bustage fix (v1).

Review of attachment 8710501 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! r=mkmelin
Will land it shortly
Attachment #8710501 - Flags: review?(mkmelin+mozilla) → review+

Comment 6

a year ago
https://hg.mozilla.org/comm-central/rev/dd897b58de43 -> FIXED
Assignee: nobody → mozilla
Severity: normal → blocker
Status: NEW → RESOLVED
Last Resolved: a year ago
Keywords: regression
Resolution: --- → FIXED

Comment 7

a year ago
(at least for linux the compile succeeds w/ this)

Comment 8

a year ago
What is this new parameter for?
(Assignee)

Comment 9

a year ago
(In reply to Magnus Melin from comment #7)
> (at least for linux the compile succeeds w/ this)
My try for Windows fell over, so perhaps your push has more luck.

(In reply to aleth [:aleth] from comment #8)
> What is this new parameter for?
No idea, ask the author in the other bug.

Updated

a year ago
Target Milestone: --- → Thunderbird 46.0
(Assignee)

Comment 10

a year ago
Complete rebuild fixed the std problems from the bottom comment #2. Case closed.
(Assignee)

Comment 11

a year ago
Take note: Bug 1239455 that caused the compile problem asked for Aurora uplift. If they uplift, this needs to be uplifted too.
You need to log in before you can comment on or make changes to this bug.