1241685 - Link Gecko preference with java telemetry server preference

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In bug 1205835, we grab the telemetry server from SharedPreferences, but nobody ever updates the shared preference value – we should sync the Gecko preference with the Java SharedPreference so users can change their telemetry servers and have this sync with the Gecko Telemetry uploader.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Another approach: intents.

06:57 <@mfinkle> mcomella, mkaply: we could make changing the telemetry URL work like the Switchboard approach
06:57 <@mfinkle> https://github.com/mozilla-services/switchboard-experiments#making-config-changes
06:57 <@mfinkle> adb shell am start --es "switchboard-host" "switchboard.stage.mozaws.net" <package-name>

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #1)
> Another approach: intents.

I prefer the gecko preference because 1) it's more discoverable, 2) it'll be easier to access for testers, particularly on release builds, & 3) we don't have to worry about the security implications of intent handling.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1241685 - Add TelemetryPreferences.

Review commit: https://reviewboard.mozilla.org/r/58632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58632/

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1241685 - Hook up TelemetryPreferences for telemetry server url.

In this patch, I move the telemetry server preference from app preferences
to per-profile preferences. We never allowed the user to set the preference
so this should cause no issues.

Review commit: https://reviewboard.mozilla.org/r/58634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58634/

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1241685 - Add brief javadoc to assist with testing.

Review commit: https://reviewboard.mozilla.org/r/58636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58636/

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8761435 [details]
Bug 1241685 - Add TelemetryPreferences.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58632/diff/1-2/

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8761436 [details]
Bug 1241685 - Hook up TelemetryPreferences for telemetry server url.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58634/diff/1-2/

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

fwiw, I filed bug 1279114 for the enabled state which works well enough and I don't think is worth fixing right now.

Comment 9

[Andrzej Hunt :ahunt]

Comment on attachment 8761435 [details]
Bug 1241685 - Add TelemetryPreferences.

https://reviewboard.mozilla.org/r/58632/#review55672

Comment 10

[Andrzej Hunt :ahunt]

Comment on attachment 8761436 [details]
Bug 1241685 - Hook up TelemetryPreferences for telemetry server url.

https://reviewboard.mozilla.org/r/58634/#review55674

Comment 11

[Andrzej Hunt :ahunt]

Comment on attachment 8761438 [details]
Bug 1241685 - Add brief javadoc to assist with testing.

https://reviewboard.mozilla.org/r/58636/#review55676

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/6d374697de7a07f8ca3a3e4f7dcaa7e38e788c6e
Bug 1241685 - Add TelemetryPreferences. r=ahunt

https://hg.mozilla.org/integration/fx-team/rev/144f108be3b3552e66f601cc86beb1ac494555ec
Bug 1241685 - Hook up TelemetryPreferences for telemetry server url. r=ahunt

https://hg.mozilla.org/integration/fx-team/rev/afc529c199066e9c9d8a88318f24f631a7678d53
Bug 1241685 - Add brief javadoc to assist with testing. r=ahunt

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d374697de7a
https://hg.mozilla.org/mozilla-central/rev/144f108be3b3
https://hg.mozilla.org/mozilla-central/rev/afc529c19906