Closed Bug 1241702 Opened 4 years ago Closed 4 years ago

Allow DEPTH_STENCIL as an RB format for WebGL 2

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file)

This is explicitly supported in the WebGL 2 spec.
Attachment #8710760 - Flags: review?(jmuizelaar)
Comment on attachment 8710760 [details] [diff] [review]
0001-Allow-DEPTH_STENCIL-as-an-RB-sizedFormat.patch

Review of attachment 8710760 [details] [diff] [review]:
-----------------------------------------------------------------

with nit.

::: dom/canvas/WebGLFormats.cpp
@@ +833,4 @@
>          AddSimpleUnsized(ptr, LOCAL_GL_RGB , LOCAL_GL_HALF_FLOAT_OES, EffectiveFormat::RGB16F );
>      }
>  
> +

Don't need the extra NL here.
Attachment #8710760 - Flags: review?(jmuizelaar) → review+
Depends on: 1240438
https://hg.mozilla.org/mozilla-central/rev/2d6c048be092
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Blocks: 1240438
No longer depends on: 1240438
You need to log in before you can comment on or make changes to this bug.