Closed Bug 1290018 Opened 3 years ago Closed 3 years ago

[WebGL2] pass gl.getInternalformatParameter() in gl-object-get-calls.html

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jerry, Assigned: jerry)

References

Details

Attachments

(1 file)

getInternalformatParameter() should return invalid enum with DEPTH_STENCIL.

gles spec 3.0.4 p212
An internal format is depth-renderable if it is one of the formats from table 3.14. No other formats are depth-renderable.

In table 3.14 (p133), DEPTH_STENCIL is not in that table.
Sorry, comment 0 is incorrect.

In webgl2 spec:
void renderbufferStorage(GLenum target, GLenum internalformat, GLsizei width, GLsizei height) (OpenGL ES 3.0.4 §4.4.2, man page)
Accepts internal formats from OpenGL ES 3.0 as detailed in the specification and man page.
To be backward compatible with WebGL 1, also accepts internal format DEPTH_STENCIL, which should be mapped to DEPTH24_STENCIL8 by implementations.

So the DEPTH_STENCIL is valid.
Please check Bug 1241702.
See Also: → 1241702
Is my understanding correct for comment 1?
Flags: needinfo?(jgilbert)
(In reply to Jerry Shih[:jerry] (UTC+8) from comment #3)
> Is my understanding correct for comment 1?

Yes though technically I don't think this exception necessarily applies to getInternalformatParameter.
It should though.
Flags: needinfo?(jgilbert)
Add DEPTH_STENCIL to depth-renderable list.
https://github.com/KhronosGroup/WebGL/pull/1945

Just pick that change.
Attachment #8775830 - Flags: review?(jgilbert)
Attachment #8775830 - Flags: review?(jgilbert) → review+
cherry-pick webgl conformance patch.
Please the attachment 8775830 [details] [diff] [review] to m-c.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22b93575a3d9
update webgl conformance tests. r=jgilbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/22b93575a3d9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.