Closed
Bug 1241857
Opened 8 years ago
Closed 8 years ago
[Lint: MissingSuperCall] Missing super call.
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: vivek, Assigned: maurya1985)
References
Details
(Whiteboard: [lang=java][good next bug])
Attachments
(1 file, 1 obsolete file)
6.49 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
This is a bug to track missing super call in the following code. 1. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarEditText.java?from=ToolbarEditText.java#94 2. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarEditLayout.java?from=ToolbarEditLayout.java#81 3. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarDisplayLayout.java?from=ToolbardisplayLayout.java#193 4. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/toolbar/ShapedButton.java?from=ShapedButton.java#47 5. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/PanelsPreferenceCategory.java?from=PanelsPreferenceCategory.java#172 6. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/gfx/LayerView.java?from=LayerView.java#270
Blocks: android-lint
Run `./mach gradle app:lint` for the most up-to-date list.
Summary: [Lint] Missing super call. → [Lint: MissingSuperCall] Missing super call.
Assignee | ||
Comment 2•8 years ago
|
||
Michael, can you assign this bug to me?
Assignee | ||
Comment 3•8 years ago
|
||
[2] and [3] seem to have already been addressed. Will add a patch for the remaining.
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8728847 -
Flags: review?(vivekb.balakrishnan)
Assignee: nobody → maurya1985
Comment on attachment 8728847 [details] [diff] [review] lint-MissingSuperCall Review of attachment 8728847 [details] [diff] [review]: ----------------------------------------------------------------- Nice! Thanks for the patch! Can you also add a commit to convert this lint warning to an error? You can do so in the mobile/android/applint.xml file: https://mxr.mozilla.org/mozilla-central/source/mobile/android/app/lint.xml#36
Attachment #8728847 -
Flags: review?(vivekb.balakrishnan) → review+
By the way, if you like fixing these lint issues, feel free to run `mach gradle app:lint` and file new ones blocking the meta bug 1170283. It'd be good to prioritize the ones with the most useful lint warnings. I'm excited to finally see lint taking off! :)
Comment on attachment 8728847 [details] [diff] [review] lint-MissingSuperCall Review of attachment 8728847 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/java/org/mozilla/gecko/toolbar/ShapedButton.java @@ +44,5 @@ > } > > @Override > public void draw(Canvas canvas) { > + super.draw(canvas); Actually, this gets called from `defaultDraw` and intentionally doesn't get called in the other case. Can you suppress the error here? It causes the toolbar curve to not appear.
Attachment #8728847 -
Flags: review+ → review-
Assignee | ||
Comment 9•8 years ago
|
||
Michael, thanks for the review! Attached the new patch in which I converted the lint warning to an error. Also, suppressed the warning for ShapedButton.draw(). And sure, I'll see if any other lint related bugs interest me.
Attachment #8728847 -
Attachment is obsolete: true
Attachment #8730103 -
Flags: review?(michael.l.comella)
Comment on attachment 8730103 [details] [diff] [review] lint-MissingSuperCall Review of attachment 8730103 [details] [diff] [review]: ----------------------------------------------------------------- Baller! Thanks Maurya!
Attachment #8730103 -
Flags: review?(michael.l.comella) → review+
Keywords: checkin-needed
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9034f1d7db43
Keywords: checkin-needed
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9034f1d7db43
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•