Closed Bug 1241857 Opened 4 years ago Closed 4 years ago

[Lint: MissingSuperCall] Missing super call.

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: vivek, Assigned: maurya1985)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=java][good next bug])

Attachments

(1 file, 1 obsolete file)

Run `./mach gradle app:lint` for the most up-to-date list.
Summary: [Lint] Missing super call. → [Lint: MissingSuperCall] Missing super call.
Michael, can you assign this bug to me?
[2] and [3] seem to have already been addressed. Will add a patch for the remaining.
Attached patch lint-MissingSuperCall (obsolete) — Splinter Review
Attachment #8728847 - Flags: review?(vivekb.balakrishnan)
Assignee: nobody → maurya1985
Comment on attachment 8728847 [details] [diff] [review]
lint-MissingSuperCall

Review of attachment 8728847 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thanks for the patch!

Can you also add a commit to convert this lint warning to an error? You can do so in the mobile/android/applint.xml file:
  https://mxr.mozilla.org/mozilla-central/source/mobile/android/app/lint.xml#36
Attachment #8728847 - Flags: review?(vivekb.balakrishnan) → review+
By the way, if you like fixing these lint issues, feel free to run `mach gradle app:lint` and file new ones blocking the meta bug 1170283. It'd be good to prioritize the ones with the most useful lint warnings.

I'm excited to finally see lint taking off! :)
Comment on attachment 8728847 [details] [diff] [review]
lint-MissingSuperCall

Review of attachment 8728847 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/toolbar/ShapedButton.java
@@ +44,5 @@
>      }
>  
>      @Override
>      public void draw(Canvas canvas) {
> +        super.draw(canvas);

Actually, this gets called from `defaultDraw` and intentionally doesn't get called in the other case. Can you suppress the error here? It causes the toolbar curve to not appear.
Attachment #8728847 - Flags: review+ → review-
Michael, thanks for the review! Attached the new patch in which I converted the lint warning to an error. Also, suppressed the warning for ShapedButton.draw(). And sure, I'll see if any other lint related bugs interest me.
Attachment #8728847 - Attachment is obsolete: true
Attachment #8730103 - Flags: review?(michael.l.comella)
Comment on attachment 8730103 [details] [diff] [review]
lint-MissingSuperCall

Review of attachment 8730103 [details] [diff] [review]:
-----------------------------------------------------------------

Baller! Thanks Maurya!
Attachment #8730103 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/9034f1d7db43
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.