1241857 - [Lint: MissingSuperCall] Missing super call.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivek Balakrishnan[:vivek]]

This is a bug to track missing super call in the following code.

1. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarEditText.java?from=ToolbarEditText.java#94
2. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarEditLayout.java?from=ToolbarEditLayout.java#81
3. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarDisplayLayout.java?from=ToolbardisplayLayout.java#193
4. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/toolbar/ShapedButton.java?from=ShapedButton.java#47
5. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/PanelsPreferenceCategory.java?from=PanelsPreferenceCategory.java#172
6. https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/gfx/LayerView.java?from=LayerView.java#270

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Run `./mach gradle app:lint` for the most up-to-date list.

Comment 2

[Maurya Talisetti]

Michael, can you assign this bug to me?

Comment 3

[Maurya Talisetti]

[2] and [3] seem to have already been addressed. Will add a patch for the remaining.

Comment 4

[Maurya Talisetti]

Attachment: lint-MissingSuperCall

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8728847 [details] [diff] [review]
lint-MissingSuperCall

Review of attachment 8728847 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thanks for the patch!

Can you also add a commit to convert this lint warning to an error? You can do so in the mobile/android/applint.xml file:
  https://mxr.mozilla.org/mozilla-central/source/mobile/android/app/lint.xml#36

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

By the way, if you like fixing these lint issues, feel free to run `mach gradle app:lint` and file new ones blocking the meta bug 1170283. It'd be good to prioritize the ones with the most useful lint warnings.

I'm excited to finally see lint taking off! :)

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b52b8569e1e

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8728847 [details] [diff] [review]
lint-MissingSuperCall

Review of attachment 8728847 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/toolbar/ShapedButton.java
@@ +44,5 @@
>      }
>  
>      @Override
>      public void draw(Canvas canvas) {
> +        super.draw(canvas);

Actually, this gets called from `defaultDraw` and intentionally doesn't get called in the other case. Can you suppress the error here? It causes the toolbar curve to not appear.

Comment 9

[Maurya Talisetti]

Attachment: lint-MissingSuperCall

Michael, thanks for the review! Attached the new patch in which I converted the lint warning to an error. Also, suppressed the warning for ShapedButton.draw(). And sure, I'll see if any other lint related bugs interest me.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8730103 [details] [diff] [review]
lint-MissingSuperCall

Review of attachment 8730103 [details] [diff] [review]:
-----------------------------------------------------------------

Baller! Thanks Maurya!

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a490b865d10

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9034f1d7db43

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9034f1d7db43