[Lint: CommitTransaction] Fix Missing Fragment transaction commit call

NEW
Unassigned

Status

()

Firefox for Android
General
2 years ago
2 years ago

People

(Reporter: vivek, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
In TabHistoryFragment commit is called in show step [1]. However, Lint complains at the caller [2] about missing commit call. To fix this either refactor the show() function to create a new fragment transaction instead of passing it along or add SuppressLint annotation for CommitTransaction.

[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/tabs/TabHistoryFragment.java?case=true&from=TabHistoryFragment.java#125

[2] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java?from=BrowserAPp.java#615
Summary: [Lint] Fix Missing Fragment transaction commit call → [Lint: CommitTransaction] Fix Missing Fragment transaction commit call
You need to log in before you can comment on or make changes to this bug.