[Lint: ScrollViewSize] Fix ScrollView size validation error

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: vivek, Assigned: malayaleecoder, NeedInfo)

Tracking

(Blocks 1 bug)

unspecified
Firefox 47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Comment 1

3 years ago
Posted patch Bug1241941_v1.diff (obsolete) — Splinter Review
The first file in the above mentioned list is not found. Made the change in the other two files. Please have a look.
Flags: needinfo?(vivekb.balakrishnan)
Assignee

Updated

3 years ago
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(michael.l.comella)
Summary: [Lint] Fix ScrollView size validation error → [Lint: ScrollViewSize] Fix ScrollView size validation error
Comment on attachment 8725385 [details] [diff] [review]
Bug1241941_v1.diff

Review of attachment 8725385 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! However, the code for the first file was moved here:
  https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/firstrun_basepanel_fragment.xml#14

Can you update that one too?

btw, you can find the most up-to-date lint issues by running `mach gradle app:lint` and opening the result file.
Attachment #8725385 - Flags: feedback+
Assignee: nobody → malayaleecoder
Assignee

Comment 3

3 years ago
Hello Comella

I was not able to run 'mach gradle app:lint' as it thrower out some error(which I will get it fixed from IRC). Anyway, I have done the necessary changes to the first file also. Please check.

Cheers.
Attachment #8725385 - Attachment is obsolete: true
Attachment #8725662 - Flags: review?(michael.l.comella)
Reporter

Comment 4

3 years ago
Comment on attachment 8725662 [details] [diff] [review]
Bug1241941_v2.diff

Review of attachment 8725662 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Micheal,
Can you please do a super review?
Attachment #8725662 - Flags: review?(michael.l.comella)
Attachment #8725662 - Flags: review+
Comment on attachment 8725662 [details] [diff] [review]
Bug1241941_v2.diff

Review of attachment 8725662 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Let me know if you need help trying to get your linting working!

Just so you know, I filed a follow-up (bug 1253126) to make sure future failures appear as lint errors, rather than just a warning.
Attachment #8725662 - Flags: review?(michael.l.comella) → review+
Don't forget to add checkin-needed!
Assignee

Updated

3 years ago
Keywords: checkin-needed
Assignee

Updated

3 years ago
Status: NEW → ASSIGNED

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/996d83c26f6f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.