124203 - Cancel button and % indicator in Progress panel gets pushed to the right

Status: RESOLVED WORKSFORME

(Core :: Printing: Output, defect, P3)

Description

[sujay]

using 2/7 trunk build of netscape

1) launch netscape
2) print a long URL

notice the progress panel pops up briefly.

Notice the Cancel button get pushed to the right, and you can only
see part of the button. Looks like Cancel button moves off the panel
relative to how long the URL is.

Comment 1

[Andreas Premstaller]

Confirming using 2002020803 on W2K. 
Attaching pictures, since this is a bit difficult to spot.

Comment 2

[Andreas Premstaller]

Attachment: Picture 1: During printing everything seems okay...

Comment 3

[Andreas Premstaller]

Attachment: Picture 2: but at the end, the button shifts to the right, and the text is cut off.

Comment 4

[Andreas Premstaller]

Attachment: Proposed patch

Comment 5

[Andreas Premstaller]

This bug has exactly the same cause as (the remainder of) bug 79889. According
to the grid definition in printProgress.xul, the dialog has two columns, but the
second row has three elements to fill those columns. The third element, the
label saying 100%, only becomes visible when printing is complete, and shifts
the button out to the right. 
The fix is to pack progressmeter and label into one hbox, the label then needs a
fixed width to avoid "shrinking" of the progressmeter once printing is complete.

rods, can you please look at the patch and review it?

Comment 6

[rods (gone)]

Th patch isn't quite right, because the progress meter isn't as long as the url
now. I am gonig to reassign this to a UI guy for help.

Comment 7

[Andreas Premstaller]

The length of the progress meter is limited by the fixed-width text-label next
to it, that in this dialog is empty during printing, and only shows "100%" at
the end. If I make the progress meter larger during the printing, it will jump
to a smaller size once the text "100%" is shown, which ism't very pretty either. 

Comment 8

[Samir Gehani]

Attachment: Revised Andreas's patch to satisfy Rod's concern.

Comment 9

[Samir Gehani]

rods, please r.
alecf, please sr.

Comment 10

[Alec Flett]

Comment on attachment 69736 [details] [diff] [review]
Revised Andreas's patch to satisfy Rod's concern.

sr=alecf

Comment 11

[Stephen P. Morse]

Comment on attachment 69736 [details] [diff] [review]
Revised Andreas's patch to satisfy Rod's concern.

r=morse

Comment 12

[Samir Gehani]

Checked in.

Comment 13

[sujay]

Samir, look at bug 128278 ....That bug is a DUP of this one, should I 
reopen this bug ?

Comment 14

[sujay]

REOPENING because I found a URL that still exhibits the problem.

1) launch netscape
2) click above URL
3) Print

look at how the cancel button gets pushed to the right in the progress
panel. The above URL is an average length URL. There are URL's out there
that are longer, this Cancel button will disappear off the panel very easily.

Also reopening because we got another bug report on this issue which I will
DUP to this bug...

Comment 15

[sujay]

*** Bug 128278 has been marked as a duplicate of this bug. ***

Comment 16

[sujay]

Ansgar, please provide the URL you printed as a 2nd testcase..thanks...

Comment 17

[Andreas Premstaller]

I propose replacing <label id="dialog.status"/> in printProgress.xul by        
      <textbox id="dialog.status" class="scrollfield" readonly="" flex="1"/>
(with a flex="1" in the 2nd column of the grid.

However, I think it would be nicer and a better use of the available space to
have the textbox expand over the progressmeter and the space for the 100% text
(using a grid of just 2 columns and combining progressmeter and label in one
hbox, as proposed in attachment 68985 [details] [diff] [review]).

Comment 18

[Andreas Premstaller]

Attachment: Compare 2 possible patches

I tried to change the grid as I said in comment #17, and it just looks ugly
without a numerical percentage indication during printing, see upper dialog.
Therefore, I attach a patch that keeps the grid and just puts the printed url
in a textbox (in analogy to the download window).

Comment 19

[Andreas Premstaller]

Attachment: Patch to put printed url in textbox.

Comment 20

[Andreas Premstaller]

Put a really long testcase into the url (courtesy of asa and mozillazine).

Comment 21

[sujay]

forgot to mention its also the percent indicator on the panel that gets pushed
off as stated in the DUP bug..

Comment 22

[Ansgar Schrage]

Attachment: URL that I used as a testcase

Here is the URL that I used and that revealed the problem to me. The page is in
German, but I hope that dosn't matter.

Comment 23

[scottputterman]

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to [e-mail].  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.

Comment 24

[Zook Valem]

Attachment: 2nd testcase of an URL

Here's the additional testcase to this bug.....

Comment 25

[Zook Valem]

The testcase's date '2002-03-01' doesn't show this problem when printing.  So,
I'm enclosing another testcase (another URL) of this bug that occur when
attempting to print.  I haven't tested it with the Netscape browser and this
problem occur with the Mozilla Build ID# 2002-12-07-04.

Wait until the percentage get around 80% then you'll noticed that the 'Cancel'
button start getting push out of the 'Print Dialog Box' or whatever the pop-up
box is called.

I do not understand Comment #23, so please leave this bug as re-opened for this
comment.  Thanks!!

Comment 26

[Wayne Mery (:wsmwk)]

WFM - I don't see this.  gone?

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060516 SeaMonkey/1.0.2

Comment 27

[Wayne Mery (:wsmwk)]

Comment on attachment 72390 [details]
URL that I used as a testcase

URL no longer works

Comment 28

[Wayne Mery (:wsmwk)]

WFM
Please reopen if you still see this bug on a recent version