Fix use of s3cfg_* in release_s3_credentials for windows

RESOLVED FIXED

Status

Infrastructure & Operations
RelOps: Puppet
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8711244 [details] [diff] [review]
[puppet] s3_creds

This is breaking b-2008 instances puppet run.

The patch itself is untested, and while looking at it I am worried slightly that it also breaks any dev/pp instances being puppetized (no content defined for those files)
Attachment #8711244 - Flags: review?(mcornmesser)
Attachment #8711244 - Flags: feedback?(coop)

Comment 1

3 years ago
Comment on attachment 8711244 [details] [diff] [review]
[puppet] s3_creds

Review of attachment 8711244 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine, but we don't actually need these files on Windows. If you want to simply prevent them from being installed, that might be better.
Attachment #8711244 - Flags: feedback?(coop) → feedback+
Attachment #8711244 - Flags: review?(mcornmesser) → review+
(Assignee)

Comment 2

3 years ago
Comment on attachment 8711244 [details] [diff] [review]
[puppet] s3_creds

https://hg.mozilla.org/build/puppet/rev/ddac98fbcfd8
 (landed on default)
Attachment #8711244 - Flags: checked-in+
Assignee: relops → bugspam.Callek
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.