Closed Bug 1242088 Opened 9 years ago Closed 8 years ago

Fix use of s3cfg_* in release_s3_credentials for windows

Categories

(Infrastructure & Operations :: RelOps: Puppet, task)

Product:
Infrastructure & Operations
Component:
RelOps: Puppet
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(1 file)

[puppet] s3_creds
1.11 KB, patch
markco
: review+
coop
: feedback+
Callek
: checked-in+
Details | Diff | Splinter Review
This is breaking b-2008 instances puppet run. The patch itself is untested, and while looking at it I am worried slightly that it also breaks any dev/pp instances being puppetized (no content defined for those files)
Attachment #8711244 - Flags: review?(mcornmesser)
Attachment #8711244 - Flags: feedback?(coop)
Comment on attachment 8711244 [details] [diff] [review] [puppet] s3_creds Review of attachment 8711244 [details] [diff] [review]: ----------------------------------------------------------------- Patch looks fine, but we don't actually need these files on Windows. If you want to simply prevent them from being installed, that might be better.
Attachment #8711244 - Flags: feedback?(coop) → feedback+
Attachment #8711244 - Flags: review?(mcornmesser) → review+
Comment on attachment 8711244 [details] [diff] [review] [puppet] s3_creds https://hg.mozilla.org/build/puppet/rev/ddac98fbcfd8 (landed on default)
Attachment #8711244 - Flags: checked-in+
Assignee: relops → bugspam.Callek
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: