Closed Bug 1242152 Opened 5 years ago Closed 5 years ago

1241476 broke sndio builds

Categories

(Core :: Audio/Video: cubeb, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: gaston, Unassigned, NeedInfo)

References

Details

Attachments

(1 file)

Attached file cubeb-sndio
Havent been cced on recent webrtc /cubeb changes, the build fails since 1241476.
Trivial fix seem to be adding NULL as third arg to data_cb(), no idea if more should be done, but at least it builds.

Dunno if that should be upstreamed somewhere first on github, which way things are supposed to go those days..
Blocks: 1241476
Flags: needinfo?(rjesup)
Comment on attachment 8711338 [details]
cubeb-sndio

https://hg.mozilla.org/mozilla-central/rev/c4db43c72f53#l6.12 is why i did this proposal fix - no idea how it'll work at runtime.
Flags: needinfo?(alex)
Attachment #8711338 - Flags: feedback?(kinetik)
Comment on attachment 8711338 [details]
cubeb-sndio

Yeah.  The WebRTC team are in the process of adding full-duplex (input and output) streams to libcubeb (the "tier 1" backends, anyway).

Sorry it broke, I wish we had the CI infrastructure to catch stuff like this.

I've upstreamed your fix here: https://github.com/kinetiknz/cubeb/commit/2d8fc9358505cd87c5596cff142f1dc497e2a1ff

To update the in-tree version, run media/libcubeb/update.sh path-to-git-checkout.  I think it's the only change since the last update, so if you've got commit access go ahead and land that update, otherwise let me know and I'll land it.
Attachment #8711338 - Flags: feedback?(kinetik) → feedback+
https://hg.mozilla.org/mozilla-central/rev/038b2414e772
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Flags: needinfo?(rjesup)
You need to log in before you can comment on or make changes to this bug.