1242152 - 1241476 broke sndio builds

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Landry Breuil (:gaston)]

Attachment: cubeb-sndio

Havent been cced on recent webrtc /cubeb changes, the build fails since 1241476.
Trivial fix seem to be adding NULL as third arg to data_cb(), no idea if more should be done, but at least it builds.

Dunno if that should be upstreamed somewhere first on github, which way things are supposed to go those days..

Comment 1

[Landry Breuil (:gaston)]

Comment on attachment 8711338 [details]
cubeb-sndio

https://hg.mozilla.org/mozilla-central/rev/c4db43c72f53#l6.12 is why i did this proposal fix - no idea how it'll work at runtime.

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8711338 [details]
cubeb-sndio

Yeah.  The WebRTC team are in the process of adding full-duplex (input and output) streams to libcubeb (the "tier 1" backends, anyway).

Sorry it broke, I wish we had the CI infrastructure to catch stuff like this.

I've upstreamed your fix here: https://github.com/kinetiknz/cubeb/commit/2d8fc9358505cd87c5596cff142f1dc497e2a1ff

To update the in-tree version, run media/libcubeb/update.sh path-to-git-checkout.  I think it's the only change since the last update, so if you've got commit access go ahead and land that update, otherwise let me know and I'll land it.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/038b2414e772

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/038b2414e772