Closed Bug 1242262 Opened 4 years ago Closed 4 years ago

Build failure with opt builds compiled using --enable-gczeal

Categories

(Core :: JavaScript: GC, defect, blocker)

x86_64
macOS
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: gkw, Assigned: ehoogeveen)

References

Details

Attachments

(1 file)

I'm now unable to compile opt builds with the following options:

CC="clang -Qunused-arguments" CXX="clang++ -Qunused-arguments" AR=ar AUTOCONF=/usr/local/Cellar/autoconf213/2.13/bin/autoconf213 sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=x86_64-apple-darwin12.5.0 --enable-more-deterministic --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/a048c55e1906
user:        Terrence Cole
date:        Wed Jan 13 12:28:18 2016 -0800
summary:     Bug 1239314 - Make marking validation a normal zeal mode; r=jonco

Terrence, is bug 1239314 a likely regressor?
Flags: needinfo?(terrence)
Looks like the patch missed some instances of JS_GC_MARKING_VALIDATION. I converted the last vestiges to JS_GC_ZEAL and removed the define, since IIUC it's just a normal zeal mode now. By the way, I noticed some (probably unrelated) unused variable warnings, those might be worth looking into.

This patch fixes compilation for me - Gary, can you confirm?

I tried to push this to Try, but apparently my account has been deactivated due to inactivity. Whoops. Filed bug 1242262 about that.
Assignee: nobody → emanuel.hoogeveen
Status: NEW → ASSIGNED
Flags: needinfo?(gary)
Attachment #8711471 - Flags: review?(terrence)
(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #1)
> I tried to push this to Try, but apparently my account has been deactivated
> due to inactivity. Whoops. Filed bug 1242262 about that.

I meant bug 1242265.
(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #1)
> This patch fixes compilation for me - Gary, can you confirm?

Thanks for the quick patch! Yes I confirm that this fixes compilation for me too.
Comment on attachment 8711471 [details] [diff] [review]
Remove the last vestiges of JS_GC_MARKING_VALIDATION (it's a GC Zeal mode now).

Review of attachment 8711471 [details] [diff] [review]:
-----------------------------------------------------------------

D'oh! Could have sworn I fixed those hunks in the first patch!
Attachment #8711471 - Flags: review?(terrence) → review+
Pushed this [fuzzblocker] fix to treeherder on behalf. Thanks for fixing!
Flags: needinfo?(terrence)
Flags: needinfo?(gary)
https://hg.mozilla.org/mozilla-central/rev/ddaa87cfd7fa
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.