1242324 - Prefer VP9 over vp8 by default in createOffer() in WebRTC

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

Note that really the optimal solution would be to dynamically choose codecs according to bandwidth *and* CPU use.  Low-perf devices with plenty of bandwidth may prefer VP8/H264, or if they have a HW codec for vp8/264.  When bandwidth is low, VP9 may be best even if it uses more CPU.  When maxing out on bandwidth, VP8/264 may be better due to less CPU, and negligible gains for switching to a more-efficient codec, unless it's to reduce bandwidth at the same quality.

All that said, the first step is to prefer VP9 in offers (when we're preffed on).

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Give VP9 priority over vp8 when both are enabled

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8711554 [details] [diff] [review]
Give VP9 priority over vp8 when both are enabled

Whomever I get first...

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8711554 [details] [diff] [review]
Give VP9 priority over vp8 when both are enabled

Review of attachment 8711554 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/329f6c0221e8

Comment 5

[Nils Ohlmeier [:drno]]

Attachment: jsep_session_test.patch

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/329f6c0221e8

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

This followup landed under a different bug number: (cpp unittest fix)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0254596dc66
https://hg.mozilla.org/mozilla-central/rev/a0254596dc66

Comment 8

[Nils Ohlmeier [:drno]]

(In reply to Randell Jesup [:jesup] from comment #7)
> This followup landed under a different bug number: (cpp unittest fix)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/a0254596dc66
> https://hg.mozilla.org/mozilla-central/rev/a0254596dc66

sorry about that. Should have not typed the bug number manually

Comment 9

[Eric Shepherd [:sheppy]]

The following documentation has been updated to note that VP9 is now the default video format for new RTCPeerConnection offers.

https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/createOffer
https://developer.mozilla.org/en-US/Firefox/Releases/46

Please advise if there are concerns left about this, docs-wise.