Closed Bug 1242324 Opened 4 years ago Closed 4 years ago

Prefer VP9 over vp8 by default in createOffer() in WebRTC

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Note that really the optimal solution would be to dynamically choose codecs according to bandwidth *and* CPU use.  Low-perf devices with plenty of bandwidth may prefer VP8/H264, or if they have a HW codec for vp8/264.  When bandwidth is low, VP9 may be best even if it uses more CPU.  When maxing out on bandwidth, VP8/264 may be better due to less CPU, and negligible gains for switching to a more-efficient codec, unless it's to reduce bandwidth at the same quality.

All that said, the first step is to prefer VP9 in offers (when we're preffed on).
Rank: 12
Comment on attachment 8711554 [details] [diff] [review]
Give VP9 priority over vp8 when both are enabled

Whomever I get first...
Attachment #8711554 - Flags: review?(drno)
Attachment #8711554 - Flags: review?(docfaraday)
Comment on attachment 8711554 [details] [diff] [review]
Give VP9 priority over vp8 when both are enabled

Review of attachment 8711554 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8711554 - Flags: review?(drno) → review+
Attachment #8711581 - Flags: review?(rjesup)
Attachment #8711554 - Flags: review?(docfaraday)
Attachment #8711581 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/329f6c0221e8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
(In reply to Randell Jesup [:jesup] from comment #7)
> This followup landed under a different bug number: (cpp unittest fix)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/a0254596dc66
> https://hg.mozilla.org/mozilla-central/rev/a0254596dc66

sorry about that. Should have not typed the bug number manually
The following documentation has been updated to note that VP9 is now the default video format for new RTCPeerConnection offers.

https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/createOffer
https://developer.mozilla.org/en-US/Firefox/Releases/46

Please advise if there are concerns left about this, docs-wise.
You need to log in before you can comment on or make changes to this bug.