Closed Bug 1242327 Opened 8 years ago Closed 8 years ago

Running operatorvariant build.js on node.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

Attachments

(1 file)

apps/operatorvariant/build/build.js contains certain XPConnect APIs that should be converted to Node.js compatible version. 

Separate it from bug 1240740 since this should be verified carefully.
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Comment on attachment 8711732 [details] [review]
[gaia] rickychien:operatorvariant-build-to-node > mozilla-b2g:master

"A gift everyday keeps the doctor away"
Attachment #8711732 - Flags: review?(scwwu)
Comment on attachment 8711732 [details] [review]
[gaia] rickychien:operatorvariant-build-to-node > mozilla-b2g:master

Looks good to me. Thanks. r+
Attachment #8711732 - Flags: review?(scwwu) → review+
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/ae7b326f34914a2de253625c1f0a304996df1f1b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: