1242459 - Replace dump() in testing/marionette/actions.js with logger

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

testing/marionette/actions.js:118 uses dump() to log debug information.  This ought to be replaced with a logger instance:

    https://dxr.mozilla.org/mozilla-central/source/testing/marionette/actions.js#118

Note that this might be a bit tricky because this file is loaded using loadJsSubscript, and not Cu.import.

Comment 1

[Andreas Tolfsen ❲:ato❳]

I investigated this a bit further, and it’s not a good first bug.  As mentioned before, it requires rewriting testing/marionette/actions.js to a JS module.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1242459 - Replace dump() with logger in actions.js; r?automatedtester

Turns testing/marionette/actions.js into a JS module.

Review commit: https://reviewboard.mozilla.org/r/32653/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32653/

Comment 3

[David Burns :automatedtester]

Comment on attachment 8712798 [details]
MozReview Request: Bug 1242459 - Replace dump() with logger in actions.js; r?automatedtester

https://reviewboard.mozilla.org/r/32653/#review29433

::: testing/marionette/actions.js:120
(Diff revision 1)
> -      ") relative to the viewport\n" +
> +      "relative to the viewport, " +

can you update this to `` so that it is in keeping with the rest. It will have no affect but just looks better.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0d30139b3dd

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b0d30139b3dd