1244042 - [B2G] Marionette JavaScript Error: "TypeError: actions is undefined" {file: "chrome://marionette/content/driver.js" line: 141}

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a follow-up of Bug #1242459 +++

Since the JSMs of b2g share the same global scope [1], anything the subscript wants to export needs to be set as a member of `this` [2].

[1] Please see bug 798491.
[2] Please see bug 807478 comment 38.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8713526 [details] [diff] [review]
Patch, v1

Review of attachment 8713526 [details] [diff] [review]:
-----------------------------------------------------------------

Hi :ato, may I have your review? Please see comment #0 for the details and try result is on the way. Thank you.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8713526 [details] [diff] [review]
Patch, v1

LGTM.  Please submit patches using MozReview next time.

Comment 4

[Edgar Chen [:edgar]]

(In reply to Andreas Tolfsen (:ato) from comment #3)
> Comment on attachment 8713526 [details] [diff] [review]
> Patch, v1
> 
> LGTM.  Please submit patches using MozReview next time.

The review mercurial server is down, so I use bugzilla for review at this time. Thank you.

Comment 5

[Edgar Chen [:edgar]]

Try result looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d48cd039eb6&group_state=expanded

Comment 6

[Andreas Tolfsen ❲:ato❳]

(In reply to Edgar Chen [:edgar][:echen] from comment #4)
> (In reply to Andreas Tolfsen (:ato) from comment #3)
> > Comment on attachment 8713526 [details] [diff] [review]
> > Patch, v1
> > 
> > LGTM.  Please submit patches using MozReview next time.
> 
> The review mercurial server is down, so I use bugzilla for review at this
> time. Thank you.

Oh I didn’t know.  Please ship.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/930233c44b44

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/930233c44b44