Closed Bug 1244042 Opened 6 years ago Closed 6 years ago

[B2G] Marionette JavaScript Error: "TypeError: actions is undefined" {file: "chrome://marionette/content/driver.js" line: 141}

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

+++ This bug was initially created as a follow-up of Bug #1242459 +++

Since the JSMs of b2g share the same global scope [1], anything the subscript wants to export needs to be set as a member of `this` [2].

[1] Please see bug 798491.
[2] Please see bug 807478 comment 38.
Attached patch Patch, v1Splinter Review
Comment on attachment 8713526 [details] [diff] [review]
Patch, v1

Review of attachment 8713526 [details] [diff] [review]:
-----------------------------------------------------------------

Hi :ato, may I have your review? Please see comment #0 for the details and try result is on the way. Thank you.
Attachment #8713526 - Flags: review?(ato)
Comment on attachment 8713526 [details] [diff] [review]
Patch, v1

LGTM.  Please submit patches using MozReview next time.
Attachment #8713526 - Flags: review?(ato) → review+
(In reply to Andreas Tolfsen (:ato) from comment #3)
> Comment on attachment 8713526 [details] [diff] [review]
> Patch, v1
> 
> LGTM.  Please submit patches using MozReview next time.

The review mercurial server is down, so I use bugzilla for review at this time. Thank you.
(In reply to Edgar Chen [:edgar][:echen] from comment #4)
> (In reply to Andreas Tolfsen (:ato) from comment #3)
> > Comment on attachment 8713526 [details] [diff] [review]
> > Patch, v1
> > 
> > LGTM.  Please submit patches using MozReview next time.
> 
> The review mercurial server is down, so I use bugzilla for review at this
> time. Thank you.

Oh I didn’t know.  Please ship.
https://hg.mozilla.org/mozilla-central/rev/930233c44b44
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.