1242876 - Turn on the display before reftest testing

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Compositor will skip composition task in some code path when display off.
System app has 10s timeout setting for display. During reftest, the display might be off and break some test.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: turn on the display before reftest

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8712035 [details] [diff] [review]
turn on the display before reftest

as bug 1238464

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: turn on the display before reftest. v2

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8712651 [details] [diff] [review]
turn on the display before reftest. v2

Review of attachment 8712651 [details] [diff] [review]:
-----------------------------------------------------------------

as https://bugzilla.mozilla.org/show_bug.cgi?id=1238464#c13

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8712651 [details] [diff] [review]
turn on the display before reftest. v2

Review of attachment 8712651 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Please fix the newline at the end of the dumps.

::: layout/tools/reftest/b2g_start_script.js
@@ +55,5 @@
> +var settingResult = settingLock.set({
> +  'screen.timeout': 0
> +});
> +settingResult.onsuccess = function () {
> +  dump("Set screen.time to 0");

There needs to be a newline at the end of dump here.

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: turn on the display before reftest. v3, r=ahal

add newline in dump

Comment 7

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Please land the attachment 8712992 [details] [diff] [review] to m-c
try result:
https://treeherder.allizom.org/#/jobs?repo=try&revision=00494c387c84

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7723c3ec998

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b7723c3ec998