Closed Bug 1242876 Opened 7 years ago Closed 7 years ago

Turn on the display before reftest testing

Categories

(Testing :: Reftest, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jerry, Assigned: jerry)

Details

Attachments

(1 file, 2 obsolete files)

Compositor will skip composition task in some code path when display off.
System app has 10s timeout setting for display. During reftest, the display might be off and break some test.
Comment on attachment 8712035 [details] [diff] [review]
turn on the display before reftest

as bug 1238464
Attachment #8712035 - Flags: review?(jgriffin)
Attachment #8712035 - Flags: review?(jgriffin)
Attachment #8712035 - Attachment is obsolete: true
Attachment #8712651 - Flags: review?(ahalberstadt)
Comment on attachment 8712651 [details] [diff] [review]
turn on the display before reftest. v2

Review of attachment 8712651 [details] [diff] [review]:
-----------------------------------------------------------------

as https://bugzilla.mozilla.org/show_bug.cgi?id=1238464#c13
Comment on attachment 8712651 [details] [diff] [review]
turn on the display before reftest. v2

Review of attachment 8712651 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Please fix the newline at the end of the dumps.

::: layout/tools/reftest/b2g_start_script.js
@@ +55,5 @@
> +var settingResult = settingLock.set({
> +  'screen.timeout': 0
> +});
> +settingResult.onsuccess = function () {
> +  dump("Set screen.time to 0");

There needs to be a newline at the end of dump here.
Attachment #8712651 - Flags: review?(ahalberstadt) → review+
Attachment #8712651 - Attachment is obsolete: true
Attachment #8712992 - Attachment description: turn on the display before reftest. v3 → turn on the display before reftest. v3, r=ahal
https://hg.mozilla.org/mozilla-central/rev/b7723c3ec998
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.